Unrevert 'Upgrade stylelint-polaris to stylelint v16 (#12337)' #12350
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…`stylelint-scss`
…it from 0,2,0 to 0,5,0
It is not forwards compatible with new CSS features. See: stylelint/stylelint#7630
…ing limit from 3 to 5
Co-authored-by: Kyle Durand <kyle.durand@shopify.com>
aaronccasanova
force-pushed
the
upgrade-stylelint-polaris
branch
from
a437918 to
07c02a7
Compare
Contributor
|
stylelint has had two releases since this pr was opened; is this pr maybe ready to go? :) (Context for this ask: having @shopify/stylelint-polaris on stylelint 16 would let us adopt @shopify/stylelint-plugin 14.0.0.) |
|
Hi, I'm one of the maintainers of Stylelint. Let me know if anything on the Stylelint end is blocking landing this, and I'll do my best to unblock it. |
Contributor
|
Hi! We noticed there hasn’t been activity on this PR in a while. After 30 days, it will close automatically. If it’s still relevant, or you have updates, comment and let us know. And don’t worry, you can always re-open later if needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverting the revert of #12337, pending stylelint releasing the patch we need: stylelint/stylelint#7824