Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
ce1bee4
Upgrade `stylelint` to v16.6.1
aaronccasanova Jul 3, 2024
8e6c648
Drop support for `stylelint` v14 and v15
aaronccasanova Jul 3, 2024
c6f6e92
Apply changes from `stylelint` v16 migration guide
aaronccasanova Jul 3, 2024
9033eaf
Upgrade dependencies
aaronccasanova Jul 3, 2024
378e751
Upgrade `@shopify/stylelint-plugin` and add temporary resolution for …
aaronccasanova Jul 3, 2024
2b030ff
Apply pnpm-lock.yaml updates
aaronccasanova Jul 3, 2024
a352594
Add changeset entry
aaronccasanova Jul 3, 2024
1d847a3
Upgrade `@shopify/eslint-plugin` and minimum `eslint` version
aaronccasanova Jul 3, 2024
b80f940
Apply pnpm-lock.yaml updates
aaronccasanova Jul 3, 2024
03aa2a5
Apply `stylelint` patch to await `checkAgainstRule` function calls
aaronccasanova Jul 4, 2024
f097cb4
Prettier.format is now async
jesstelford Jul 4, 2024
3e10a44
Update lock file
jesstelford Jul 4, 2024
15267a5
prettier ignore some files that shouldn't be formatted
jesstelford Jul 4, 2024
a42749f
Fix stylelint failures for at-rule-empty-line-before
jesstelford Jul 5, 2024
8fabd55
Fix stylelint failures for selector-max-class by increasing limit fro…
jesstelford Jul 5, 2024
3e290dc
Fix stylelint failures for selector-max-combinators by increasing lim…
jesstelford Jul 5, 2024
b4b4fe3
Fix stylelint failures for selector-max-specificity by increasing lim…
jesstelford Jul 5, 2024
6a36666
Disable stylelint rule aration-block-no-redundant-longhand-properties
jesstelford Jul 5, 2024
f34efb1
Fix bugs uncovered by the stylelint declaration-property-value-no-unk…
jesstelford Jul 5, 2024
940ee8a
Fix stylelint failures for rule-empty-line-before
jesstelford Jul 5, 2024
1a2016a
Fix stylelint failures for selector-max-compound-selectors by increas…
jesstelford Jul 5, 2024
2302ade
Fix needless generic stylelint-disable rules
jesstelford Jul 5, 2024
0142d30
Fix stylelint failure for value-no-vendor-prefix
jesstelford Jul 5, 2024
46935bc
Format styles with prettier
jesstelford Jul 5, 2024
c31dc89
fix: jest lint errors
kyledurand Jul 5, 2024
760226b
Add --experimental-vm-modules flag to polaris-migrator test script
aaronccasanova Jul 5, 2024
6ea44f3
Update polaris-migrator check util to await prettier.format calls
aaronccasanova Jul 5, 2024
0b98036
Temporarily remove `styles-insert-stylelint-disable` migration
aaronccasanova Jul 5, 2024
b19c08e
Add changeset
aaronccasanova Jul 5, 2024
b3fc637
Update `stylelint` version
aaronccasanova Jul 12, 2024
07c02a7
Remove `stylelint` patch
aaronccasanova Jul 12, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/little-impalas-knock.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@shopify/stylelint-polaris': major
---

Dropped support for `stylelint` v14 and v15
5 changes: 5 additions & 0 deletions .changeset/tricky-mayflies-push.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@shopify/polaris-migrator': major
---

Removed `styles-insert-stylelint-disable` migration
3 changes: 3 additions & 0 deletions .eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@ module.exports = {
'@typescript-eslint/consistent-type-imports': 'error',
'@typescript-eslint/consistent-type-exports': 'error',
'@typescript-eslint/naming-convention': 'off',
'@typescript-eslint/consistent-indexed-object-style': 'off',
'jsx-a11y/label-has-for': [
2,
{
Expand All @@ -86,6 +87,8 @@ module.exports = {
'jsx-a11y/click-events-have-key-events': 'off',
'jsx-a11y/no-noninteractive-element-interactions': 'off',
'jsx-a11y/no-noninteractive-element-to-interactive-role': 'off',
'jest/no-conditional-in-test': 'off',
'jest/no-standalone-expect': 'off',
'no-restricted-imports': [
'error',
{
Expand Down
4 changes: 4 additions & 0 deletions .prettierignore
Original file line number Diff line number Diff line change
@@ -1,4 +1,8 @@
.next
pnpm-lock.yaml
**/CHANGELOG.md
/polaris-migrator/src/migrations/**/tests/*.scss
/polaris-migrator/templates/**/*.hbs
dist
node_modules
/polaris-react/build
Expand Down
7 changes: 7 additions & 0 deletions .stylelintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,13 @@ module.exports = {
'value-keyword-case': ['lower', {camelCaseSvgKeywords: true}],
'at-rule-no-unknown': null,
'scss/at-rule-no-unknown': true,
'selector-max-class': 5,
'selector-max-combinators': 5,
'selector-max-compound-selectors': 5,
'selector-max-specificity': '0,5,0',
// Disabling this rule as it's not forward-compatible with new CSS rules
// that get added. See: https://github.com/stylelint/stylelint/issues/7630
'declaration-block-no-redundant-longhand-properties': null,
},
overrides: [
{
Expand Down
12 changes: 6 additions & 6 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -40,28 +40,28 @@
"@rollup/plugin-replace": "^5.0.2",
"@rollup/plugin-virtual": "^3.0.1",
"@rollup/pluginutils": "^5.0.2",
"@shopify/eslint-plugin": "^42.0.1",
"@shopify/stylelint-plugin": "^11.0.0",
"@shopify/eslint-plugin": "^45.0.0",
"@shopify/stylelint-plugin": "^14.0.0",
"@shopify/typescript-configs": "^5.1.0",
"@size-limit/preset-small-lib": "^5.0.3",
"@types/jest": "^29.5.12",
"@types/node": "^20.10.0",
"babel-loader": "^9.1.2",
"eslint": "^8.3.0",
"eslint": "^8.56.0",
"eslint-plugin-storybook": "^0.8.0",
"execa": "^5.0.0",
"jest": "^29.7.0",
"jest-environment-jsdom": "^29.7.0",
"jest-preset-stylelint": "^5.0.3",
"jest-preset-stylelint": "^7.0.1",
"jest-watch-typeahead": "^2.2.2",
"js-yaml": "^4.1.0",
"npm-run-all": "^4.1.5",
"postinstall-postinstall": "^2.1.0",
"prettier": "^2.5.0",
"prettier": "^3.3.2",
"rollup": "^3.12.0",
"rollup-plugin-node-externals": "^5.1.0",
"size-limit": "^5.0.3",
"stylelint": "^14.15.0",
"stylelint": "^16.7.0",
"ts-node": "^10.7.0",
"turbo": "^1.11.1",
"typescript": "^4.9.3"
Expand Down
Loading