Dont pass "polaris" context as a prop to the div within Scrollable #1271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BPScott
force-pushed
the
scrollable-dont-pass-polaris
branch
from
f495382 to
53bd5d4
Compare
chloerice
approved these changes
Apr 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Currently the Scrollable is trying to pass the
polariscontext object into a div in the Scrollable component. That seems somewhat silly, lets not do that.You can see this in action by visiting https://polaris-react.herokuapp.com/?selectedKind=All%20Components%7CScrollable&selectedStory=Default%20scrollable%20container&full=0&addons=1&stories=1&panelRight=0&addonPanel=storybook%2Factions%2Factions-panel then running
document.querySelector('[class^="Scrollable-Scrollable"]')in your console and seeing that it has an attributepolaris="[object Object]"WHAT is this pull request doing?
This PR plucks the polaris context out of the list of properties that get passed into the
div.How to 🎩
Follow the above steps in your local storybook and see that the
polaris="[object Object]"attribute is removed