Skip to content

Conversation

BPScott
Copy link
Member

@BPScott BPScott commented Apr 2, 2019

WHY are these changes introduced?

Modal header titles css look like this:

.Title {
  flex: 1;
  margin-top: spacing(extra-tight);
  word-break: break-word;

  @include breakpoint-after($typography-condensed) {
    margin-top: rem(4px);
  }
}

Both spacing(extra-tight) and rem(4px) resolve to 0.4rem, which means that mixin is pointless.

WHAT is this pull request doing?

Removes that media query.

How to 🎩

Look at the modal dialog in storybook and assert that the title does not change position.

@BPScott BPScott temporarily deployed to polaris-react-pr-1272 April 2, 2019 01:41 Inactive
@BPScott BPScott force-pushed the modal-remove-redundant-css branch from 67578a1 to 51ea5aa Compare April 2, 2019 01:42
@BPScott BPScott temporarily deployed to polaris-react-pr-1272 April 2, 2019 01:43 Inactive
Copy link
Member

@chloerice chloerice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@BPScott BPScott force-pushed the modal-remove-redundant-css branch from 51ea5aa to f51fbc5 Compare April 2, 2019 16:22
@BPScott BPScott merged commit 20d8131 into master Apr 2, 2019
@alex-page alex-page temporarily deployed to production April 22, 2019 19:26 Inactive
@kaelig kaelig deleted the modal-remove-redundant-css branch April 26, 2019 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants