Skip to content

[ToolTip] Add border for high contrast mode #1405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 7, 2019
Merged

[ToolTip] Add border for high contrast mode #1405

merged 2 commits into from
May 7, 2019

Conversation

ruairiphackett
Copy link
Contributor

@ruairiphackett ruairiphackett commented May 3, 2019 •
edited
Loading

WHY are these changes introduced?

Partially fixes #793

WHAT is this pull request doing?

This PR adds a border to the Tooltip in Windows high contrast mode to allow it to be differentiated from the background.

Before:

https://screenshot.click/2019-05-03_11-07-53.png

After:

https://screenshot.click/2019-05-02_12-22-55.png

How to 🎩

  • Navigate to Tooltip -> All Examples in the Polaris Storybook on a Windows machine/VM running in high contrast mode

🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines

🎩 checklist

@BPScott BPScott temporarily deployed to polaris-react-pr-1405 May 3, 2019 10:14 Inactive
@ruairiphackett ruairiphackett force-pushed the tooltip-high-contrast-border branch from d0b1430 to 9102b5a Compare May 3, 2019 10:18
@BPScott BPScott temporarily deployed to polaris-react-pr-1405 May 3, 2019 10:18 Inactive
@BPScott BPScott temporarily deployed to polaris-react-pr-1405 May 3, 2019 10:20 Inactive
kaelig
kaelig reviewed May 3, 2019
View reviewed changes
@danrosenthal danrosenthal requested a review from dpersing May 6, 2019 19:49
dpersing
dpersing approved these changes May 6, 2019
View reviewed changes
Copy link

@dpersing dpersing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me! Thanks so much, @ruairiphackett.

@BPScott BPScott temporarily deployed to polaris-react-pr-1405 May 7, 2019 10:32 Inactive
@ruairiphackett ruairiphackett force-pushed the tooltip-high-contrast-border branch from 0fd3784 to 47d3f81 Compare May 7, 2019 10:40
@ruairiphackett
Copy link
Contributor Author

@kaelig @dpersing Let me know if you want me to merge this 👍

@danrosenthal
Copy link

@kaelig @dpersing Let me know if you want me to merge this 👍

Go ahead and merge once you've resolved the conflict!

@ruairiphackett ruairiphackett force-pushed the tooltip-high-contrast-border branch from 47d3f81 to a661088 Compare May 7, 2019 13:55
@BPScott BPScott requested a deployment to polaris-react-pr-1405 May 7, 2019 13:55 Abandoned
@ruairiphackett ruairiphackett merged commit bea1b69 into master May 7, 2019
@ruairiphackett ruairiphackett deleted the tooltip-high-contrast-border branch May 7, 2019 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@kaelig kaelig kaelig left review comments

@dpersing dpersing dpersing approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[a11y] Tooltips not displayed correctly with low vision settings

5 participants

@ruairiphackett @danrosenthal @kaelig @dpersing @BPScott