Fixing accessibility issues in shitlist #1565
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-page
added
the
Accessibility
ry5n
reviewed
May 24, 2019
ry5n
approved these changes
May 27, 2019
kaelig
reviewed
May 29, 2019
added 2 commits
May 29, 2019 09:06
* add accessibility label to Modal close button * upgrade a11y shitlist * add changelog * Update UNRELEASED.md Co-Authored-By: Kaelig Deloumeau-Prigent <kaelig@users.noreply.github.com> * Remove duplicate translation, remove export for CombinedProps * Switcheroo on the export
AndrewMusgrave
approved these changes
May 29, 2019
Co-Authored-By: Andrew Musgrave <andrew.musgrave@shopify.com>
Co-Authored-By: Andrew Musgrave <andrew.musgrave@shopify.com>
Co-Authored-By: Andrew Musgrave <andrew.musgrave@shopify.com>
Co-Authored-By: Andrew Musgrave <andrew.musgrave@shopify.com>
added 2 commits
May 29, 2019 14:21
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
The shitlist contained a bunch of real accessibility issues that have not been fixed.
Fixes #1458
WHAT is this pull request doing?
Fixed accessibility issues in
DropZone,Form,Modal,Section,Page,Tabs,TextFieldandTopBar.