Skip to content

[Collapsible] Add aria-controls on the button in the example #1591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 3, 2019
Merged

[Collapsible] Add aria-controls on the button in the example #1591

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c27a5b3
[Collapsible] Add aria-controls on the button in the example
kaelig May 29, 2019
3526f4d
Update UNRELEASED.md
kaelig May 29, 2019
cbb3526
Fix formating
kaelig May 29, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions UNRELEASED.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ Use [the changelog guidelines](https://git.io/polaris-changelog-guidelines) to f
### Documentation

- Updated icon documentation to use imports from polaris-icons ([#1561](https://github.com/Shopify/polaris-react/pull/1561))
- Fixed an accessibility issue in the `Collapsible` component example ([#1591](https://github.com/Shopify/polaris-react/pull/1591))

### Development workflow

Expand Down
6 changes: 5 additions & 1 deletion src/components/Collapsible/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,11 @@ class CollapsibleExample extends React.Component {
<div style={{height: '200px'}}>
<Card sectioned>
<Stack vertical>
<Button onClick={this.handleToggleClick} ariaExpanded={open}>
<Button
onClick={this.handleToggleClick}
ariaExpanded={open}
ariaControls="basic-collapsible"
>
Toggle
</Button>
<Collapsible open={open} id="basic-collapsible">
Expand Down