[TextField] Improve TextField so that character count is only announced on focus. #1720
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Try 2 for CodeCov)
WHY are these changes introduced?
We're using the TextField component inside a very long form. When switching context (e.g. changing the form data but keeping the form), we need to update the values of the form..
When doing so, the
aria-live
state of the character counters is causing them to be read out one after another without any context. I'm setting the aria-live state to off unless the TextField has focus.Feel free to slack
@emarchak
for more context on this. Related to the same problem as #1699.WHAT is this pull request doing?
I'm piggy-backing off of the existing
focus
state in the TextField component to toggle betweenoff
andpolite
to the character count.How to 🎩
🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines
Copy-paste this code in
playground/Playground.tsx
:🎩 checklist
Updated the component's(Nothing to update)README.md
with documentation changescc @Shopify/accessibility