Skip to content

Conversation

mirualves
Copy link
Contributor

@mirualves mirualves commented Jun 28, 2019

WHY are these changes introduced?

Resolves: https://github.com/Shopify/polaris-ux/issues/259

WHAT is this pull request doing?

This pull requesting is doing two things:

  • Adding a rollover state to Disclosure on Tabs (the same way we have on Home Cards.
  • Adding a rollover state for the same element for Windows High Contrast mode.

three-dot-menu-tabs-1

How to 🎩

🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines

Copy-paste this code in playground/Playground.tsx:
import * as React from 'react';
import {Page} from '@shopify/polaris';

interface State {}

export default class Playground extends React.Component<never, State> {
  render() {
    return (
      <Page title="Playground">
        {/* Add the code you want to test here */}
      </Page>
    );
  }
}

🎩 checklist

@BPScott BPScott temporarily deployed to polaris-react-pr-1755 June 28, 2019 14:35 Inactive
@mirualves mirualves requested review from alex-page and dpersing June 28, 2019 14:35
@mirualves mirualves self-assigned this Jun 28, 2019
@mirualves mirualves added the Accessibility Needs design, development, or content work relating to accessibility. label Jun 28, 2019
@BPScott BPScott temporarily deployed to polaris-react-pr-1755 June 28, 2019 14:43 Inactive
Copy link

@dpersing dpersing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Great job fitting the styles into the existing High Contrast palettes!

Copy link
Member

@alex-page alex-page left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @mirualves

@BPScott BPScott requested a deployment to polaris-react-pr-1755 July 4, 2019 17:53 Abandoned
@mirualves mirualves merged commit 5aec1cd into master Jul 4, 2019
@dleroux dleroux temporarily deployed to production July 9, 2019 15:19 Inactive
@kaelig kaelig deleted the disclosure-high-contrast branch July 12, 2019 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Accessibility Needs design, development, or content work relating to accessibility.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants