Skip to content

[Button & TextField] Add images & hide example for mobile #2081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 6, 2019
Merged

[Button & TextField] Add images & hide example for mobile #2081

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
411cf40
Update images for basic and plain buttons
see-mack Aug 29, 2019
e473fd5
Remove right-aligned textfield from mobile sections
see-mack Aug 29, 2019
1c041b3
Restrict example to be web-only
kaelig Sep 6, 2019
8cab88f
Update UNRELEASED.md
kaelig Sep 6, 2019
e224049
Merge branch 'master' into mobile-update-button-textfield-docs
kaelig Sep 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions UNRELEASED.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@ Use [the changelog guidelines](https://git.io/polaris-changelog-guidelines) to f

### Documentation

- Added Android/iOS images for Plain destructive button ([#2081](https://github.com/Shopify/polaris-react/pull/2081))
- Removed mobile mention from right-aligned text component guidelines ([#2081](https://github.com/Shopify/polaris-react/pull/2081))
- Added mobile example images error state of Single Choice List ([#2007](https://github.com/Shopify/polaris-react/pull/2007))

### Development workflow
Expand Down
16 changes: 14 additions & 2 deletions src/components/Button/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,18 @@ Use for actions that will delete merchant data or be otherwise difficult to reco
</Button>
```

<!-- content-for: android -->

![Destructive plain button for Android](/public_images/components/Button/android/plain-destructive@2x.png)

<!-- /content-for -->

<!-- content-for: ios -->

![Destructive plain button for iOS](/public_images/components/Button/ios/plain-destructive@2x.png)

<!-- /content-for -->

### Primary button

Use to highlight the most important actions in any experience. Don’t use more than one primary button in a section or screen to avoid overwhelming merchants.
Expand Down Expand Up @@ -177,13 +189,13 @@ Use when the action will delete merchant data or be otherwise difficult to recov

<!-- content-for: android -->

![Destrutive plain and destructive basic button for Android](/public_images/components/Button/android/destructive@2x.png)
![Destructive basic button for Android](/public_images/components/Button/android/basic-destructive@2x.png)

<!-- /content-for -->

<!-- content-for: ios -->

![Destrutive plain and destructive basic button for iOS](/public_images/components/Button/ios/destructive@2x.png)
![Destructive basic button for iOS](/public_images/components/Button/ios/basic-destructive@2x.png)

<!-- /content-for -->

Expand Down
2 changes: 2 additions & 0 deletions src/components/TextField/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -375,6 +375,8 @@ class LabelActionExample extends React.Component {

### TextField with right aligned text

<!-- example-for: web -->

Use when input text should be aligned right.

```jsx
Expand Down