-
Notifications
You must be signed in to change notification settings - Fork 1.2k
[Tabs] Fix vertical alignment of Tabs DisclosureActivator #2087
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
chloerice
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tophat 👀 solid 👍 ![]()
81cd0e3 to
be0da8d
Compare
ry5n
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Percy flags were either false positives, or show the Tabs issue being resolved. 👍
be0da8d to
26cf11c
Compare
AndrewMusgrave
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ✅
26cf11c to
e7a7f17
Compare
|
Looks like you've got a bunch of extra fluff in your unreleased.md, can you remove that please - you probably branched just before we cut a release |
e7a7f17 to
d6bc597
Compare
|
Anyone tell me how to make polaris tabs vertical it is horizontal by default and i need this in vertical like in list on both desktop and mobile versions. Thanks |
WHY are these changes introduced?
Fixes #2086.
WHAT is this pull request doing?
Adds
display: blockstyle to Tabs.DisclosureActivatorto match the styling of.Taband fix the vertical alignment issue.Before
After
How to 🎩
Copy-paste this code in
playground/Playground.tsx:🎩 checklist
README.mdwith documentation changes