-
Notifications
You must be signed in to change notification settings - Fork 1.2k
[Pagination] Added label prop #2098
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
ec5005e
Added label prop to Pagination
mitchmaps 2c9fea0
Updated padding of label prop to be more scalable
mitchmaps ebe3d83
Cleaned up conditional statement
mitchmaps f72001c
Further tweaks
mitchmaps 3e7a9a0
Added new test for existing a11y label prop
mitchmaps dda9de8
Added more test coverage for the a11y label
mitchmaps cf7dc0d
added support to make pagination label subdued depending on a condition
mitchmaps 60a1807
Edited inaccurate prop comment
mitchmaps d80085c
New styles for pagination buttons that have a label present
mitchmaps 1e4097f
Added new test to assert the subdued text
mitchmaps 2432c53
Response to feedback from PR review
mitchmaps 0f6e201
Edited class assigment logic
mitchmaps 93a10e5
Cleaned up some tests
mitchmaps 795176a
Added new description of Pagination with the label prop in the compon…
mitchmaps 4d746fb
Merge branch 'master' into add-label-prop-to-pagination
mitchmaps File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.