Skip to content

Conversation

dfmcphee
Copy link
Contributor

@dfmcphee dfmcphee commented Sep 27, 2019

WHY are these changes introduced?

Currently we apply a z-index to icons to allow for them to sit above the backdrop when using one. This causes strange issues in consumers because it means icons get an arbitrary z-index of 2, lifting them over things that they shouldn't be.

WHAT is this pull request doing?

This removes the z-indexes and instead changes the ::after used for the backdrop to be a ::before which naturally stacks correctly without a z-index.

How to 🎩

🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines

Ideally any regressions here will be caught by percy, but poking around in the playground to see if you can find any holes in this approach would be useful.

🎩 checklist

@dfmcphee dfmcphee requested a review from dleroux September 27, 2019 16:22
@dfmcphee dfmcphee requested a review from kaelig September 27, 2019 16:27
Copy link
Contributor

@dleroux dleroux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@dfmcphee dfmcphee merged commit afdac4e into master Sep 27, 2019
@dfmcphee dfmcphee deleted the removing-icon-z-index branch September 27, 2019 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants