[SubHeading] Fix font-weight (bold -> semibold) #2218
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaelig
requested review from
BPScott,
danrosenthal and
tmlayton
as code owners
Contributor
No changes💦 Potential splash zone of changes introduced to No significant changes to This comment automatically updates as changes are made to this pull request. |
tmlayton
reviewed
Oct 2, 2019
tmlayton
approved these changes
Oct 2, 2019
Co-Authored-By: Tim Layton <tmlayton@users.noreply.github.com>
sarahill
approved these changes
Oct 3, 2019
Contributor
sarahill
left a comment
sarahill
left a comment
There was a problem hiding this comment.
This LGTM! Thanks for doing this, Kaelig
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Related to #2214
Font-weight of subheading should be 600 (semibold), not 700 (bold), as per polaris-rails, the UI Kits, and @jessebc's specs:
WHAT is this pull request doing?
What it says in the title.
How to 🎩
🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines
Not sure what kind of tophatting is necessary here.
🎩 checklist
README.mdwith documentation changes