🐛[Sass] Fix recolor-icon mixin #2298
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR safely moves
color: $secondary-colorinto thesvgblock alongsidefill: $primary-color.Previously, the mixin was expected to be used like so:
Within the
recolor-iconmixin,fillwas scoped to to thesvgselector... butcolorwas outside of it. This meant that in the above example, mycolor: bluewill get overridden withgreen, when really my intention is to have.Componentusebluetext, while making the primary color of the iconredand the secondary color of the icongreen.