-
Notifications
You must be signed in to change notification settings - Fork 1.2k
[Tooltip] Add an example for a light tooltip #2434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
💦 Potential splash zone of changes introduced to No significant changes to This comment automatically updates as changes are made to this pull request. |
We might not want this after all. Pending discussion to remove the |
I'm guessing this one won't be needed? |
I closed the PR that would remove the |
src/components/Tooltip/README.md
Outdated
|
||
### Light tooltip | ||
|
||
Changes the background color to white. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could this include a usage guideline, rather than being a description of what this example does?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For sure! I chatted with @sarahill and @sadiesaurus and we came up with,
Light tooltip draws less attention than the default tooltip. Use only when necessary to provide an explanation for an interface element with less emphasis.
b73e4cd
to
dd8fc6f
Compare
dd8fc6f
to
8f92d93
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🐑 🇮🇹 🎩 looks good!
Co-Authored-By: Daniel Leroux <dleroux@users.noreply.github.com>
Issue summary
I was confusing instances of light colored tooltips with a Popover since it wasn't immediately obvious to me that this prop existed. This PR surfaces that prop via an example in the style guide.
I don't mind if we close this PR if we feel we don't need this addition.