Skip to content

Conversation

LauraAubin
Copy link
Contributor

Issue summary

I was confusing instances of light colored tooltips with a Popover since it wasn't immediately obvious to me that this prop existed. This PR surfaces that prop via an example in the style guide.

I don't mind if we close this PR if we feel we don't need this addition.

@LauraAubin LauraAubin requested review from dleroux and kaelig November 14, 2019 21:20
@github-actions
Copy link
Contributor

github-actions bot commented Nov 14, 2019

💦 Potential splash zone of changes introduced to src/**/*.tsx in this pull request:

No significant changes to src/**/*.tsx were detected.


This comment automatically updates as changes are made to this pull request.
Feedback, troubleshooting: open an issue or reach out on Slack in #polaris-tooling.

@LauraAubin
Copy link
Contributor Author

LauraAubin commented Nov 14, 2019

We might not want this after all. Pending discussion to remove the light prop entirely and default to light instead of dark.

@dleroux
Copy link
Contributor

dleroux commented Nov 20, 2019

I'm guessing this one won't be needed?

@LauraAubin
Copy link
Contributor Author

I'm guessing this one won't be needed?

I closed the PR that would remove the light prop with this reason meaning that this example can still be added.


### Light tooltip

Changes the background color to white.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this include a usage guideline, rather than being a description of what this example does?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For sure! I chatted with @sarahill and @sadiesaurus and we came up with,

Light tooltip draws less attention than the default tooltip. Use only when necessary to provide an explanation for an interface element with less emphasis.

@LauraAubin LauraAubin force-pushed the add-light-example-to-tooltip branch from b73e4cd to dd8fc6f Compare December 3, 2019 17:47
@LauraAubin LauraAubin force-pushed the add-light-example-to-tooltip branch from dd8fc6f to 8f92d93 Compare December 3, 2019 17:47
Copy link
Contributor

@dleroux dleroux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐑 🇮🇹 🎩 looks good!

Co-Authored-By: Daniel Leroux <dleroux@users.noreply.github.com>
@LauraAubin LauraAubin merged commit b8d32b5 into master Dec 3, 2019
@LauraAubin LauraAubin deleted the add-light-example-to-tooltip branch December 3, 2019 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants