Skip to content

[Page] print mode adjustments #2469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 26, 2019
Merged

[Page] print mode adjustments #2469

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions UNRELEASED.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
- Removed the need for z-indexes in `Icon` ([#2207](https://github.com/Shopify/polaris-react/pull/2207))
- Added `features` prop to `AppProvider` ([#2204](https://github.com/Shopify/polaris-react/pull/2204))
- Added support for using `EmptyState` in a content context ([#1570](https://github.com/Shopify/polaris-react/pull/1570))
- `Page` no longer renders navigation or actions in print mode ([#2469](https://github.com/Shopify/polaris-react/pull/2469))
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we consider this a breaking change?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd consider it a bug fix, as I think that you're right about this being expected behavior. @kaelig do you have an opinion on this?


### Bug fixes

Expand Down
6 changes: 6 additions & 0 deletions src/components/Page/components/Header/Header.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,8 @@ $action-menu-rollup-computed-width: icon-size() + (spacing(tight) * 2);
.hasActionMenu.mobileView & {
padding-right: $action-menu-rollup-computed-width;
}

@include print-hidden;
}

.BreadcrumbWrapper {
Expand Down Expand Up @@ -71,6 +73,8 @@ $action-menu-rollup-computed-width: icon-size() + (spacing(tight) * 2);
.mobileView & {
margin-top: spacing();
}

@include print-hidden;
}

.ActionMenuWrapper {
Expand All @@ -92,4 +96,6 @@ $action-menu-rollup-computed-width: icon-size() + (spacing(tight) * 2);
.mobileView.hasNavigation & {
top: control-height() / 2;
}

@include print-hidden;
}