Skip to content

Conversation

BPScott
Copy link
Member

@BPScott BPScott commented Jan 14, 2020

WHY are these changes introduced?

Keeping up to date, setting the stage for potential docs integration at a later date.

WHAT is this pull request doing?

Updates storybook to 5.3.2
Updates chromatic to 3.4.1
Performs migrations as per https://github.com/storybookjs/storybook/blob/next/MIGRATION.md. Most notably migrate to use the new config layout where presets, story listings, manager config and webpack config are all in a single file.

How to 🎩

Run storybook locally and see it all works
View uploaded stories and see they are all the same

Test hot reloading by editing the Playground / component code (both js and scss) / a component readme and see that they update without requiring a refresh

@BPScott BPScott requested a review from kaelig January 14, 2020 02:07
@github-actions
Copy link
Contributor

github-actions bot commented Jan 14, 2020

💦 Potential splash zone of changes introduced to src/**/*.tsx in this pull request:

No significant changes to src/**/*.tsx were detected.


This comment automatically updates as changes are made to this pull request.
Feedback, troubleshooting: open an issue or reach out on Slack in #polaris-tooling.

Copy link
Contributor

@kaelig kaelig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tophatted locally, it works as advertised!

@BPScott BPScott merged commit 08e2542 into master Jan 15, 2020
@BPScott BPScott deleted the update-storybook branch January 15, 2020 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants