Skip to content

[Navigation] Design language animation #2796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 16, 2020
Merged

[Navigation] Design language animation #2796

merged 2 commits into from
Mar 16, 2020

Conversation

kyledurand
Copy link
Member

@kyledurand kyledurand commented Feb 28, 2020 •
edited
Loading

WHY are these changes introduced?

This is a WIP until part 1 is merged: #2789

Screencast

WHAT is this pull request doing?

Adding animation to collapsible componennt

How to 🎩

🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines

Copy-paste this code in playground/Playground.tsx: 
import React from 'react';
import {Page} from '../src';

export function Playground() {
  return (
    <Page title="Playground">
      {/* Add the code you want to test in here */}
    </Page>
  );
}

🎩 checklist

  • Tested on mobile
  • Tested on multiple browsers
  • Tested for accessibility
  • Updated the component's README.md with documentation changes
  • Tophatted documentation changes in the style guide
  • For visual design changes, pinged one of @ HYPD, @ mirualves, @ sarahill, or @ ry5n to update the Polaris UI kit

@kyledurand kyledurand added the 🤖Skip Changelog Causes CI to ignore changelog update check. label Feb 28, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Feb 28, 2020 •
edited
Loading

🟢 This pull request modifies 5 files and might impact 3 other files.

Details:
All files potentially affected (total: 3)
🎨 src/components/Navigation/Navigation.scss (total: 1)

Files potentially affected (total: 1)

🧩 src/components/Navigation/components/Item/Item.tsx (total: 2)

Files potentially affected (total: 2)

🧩 src/components/Navigation/components/Item/components/Secondary/Secondary.tsx (total: 3)

Files potentially affected (total: 3)

🧩 src/components/Navigation/components/Item/components/Secondary/tests/Secondary.test.tsx (total: 0)

Files potentially affected (total: 0)

🧩 src/components/Navigation/components/Item/tests/Item.test.tsx (total: 0)

Files potentially affected (total: 0)

@kyledurand kyledurand force-pushed the dl_navigation-animation branch 9 times, most recently from ed30131 to 9862538 Compare March 13, 2020 15:01
@kyledurand kyledurand mentioned this pull request Mar 13, 2020
Merged
6 tasks
@kyledurand kyledurand force-pushed the dl_navigation-animation branch 2 times, most recently from cd6d379 to 4814de0 Compare March 13, 2020 18:12
@kyledurand kyledurand changed the title [WIP][Navigation] Design language animation [Navigation] Design language animation Mar 13, 2020
@kyledurand kyledurand force-pushed the dl_navigation-animation branch from 4814de0 to 5b0f828 Compare March 13, 2020 18:20
@kyledurand kyledurand merged commit 20e6ff1 into master Mar 16, 2020
@kyledurand kyledurand deleted the dl_navigation-animation branch March 16, 2020 20:14
danrosenthal added a commit that referenced this pull request Mar 20, 2020
@danrosenthal
Revert "[Navigation] Design language animation (#2796)"
1d04440 
This reverts commit 20e6ff1.
@danrosenthal danrosenthal mentioned this pull request Mar 20, 2020
Merged
danrosenthal added a commit that referenced this pull request Mar 20, 2020
@danrosenthal
Revert "[Navigation] Design language animation (#2796)" (#2864)
d9f8fd3 
This reverts commit 20e6ff1.
athornburg pushed a commit to athornburg/polaris-react that referenced this pull request Apr 15, 2020
@kyledurand @athornburg
[Navigation] Design language animation (Shopify#2796)
dcef578 
Reviewed this IRL with Tim
athornburg pushed a commit to athornburg/polaris-react that referenced this pull request Apr 15, 2020
@danrosenthal @athornburg
Revert "[Navigation] Design language animation (Shopify#2796)" (Shopi…
1bb241c 
…fy#2864)

This reverts commit 20e6ff1.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danrosenthal danrosenthal Awaiting requested review from danrosenthal

@tmlayton tmlayton Awaiting requested review from tmlayton

Assignees

No one assigned

Labels

🤖Skip Changelog Causes CI to ignore changelog update check.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@kyledurand