Skip to content

Conversation

kyledurand
Copy link
Member

WHY are these changes introduced?

This will be a major part of adding animation to the navigation component: #2796

☝️ This will be ready for review shortly after this merges

Screencast

WHAT is this pull request doing?

This adds a transition prop to collapsible which takes duration and timingFunction to allow consumers to tailor the transition to their needs.

How to 🎩

🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines

Copy-paste this code in playground/Playground.tsx:
import React from 'react';
import {Page} from '../src';

export function Playground() {
  return (
    <Page title="Playground">
      {/* Add the code you want to test in here */}
    </Page>
  );
}

🎩 checklist

  • Tested on mobile
  • Tested on multiple browsers
  • Tested for accessibility
  • Updated the component's README.md with documentation changes
  • Tophatted documentation changes in the style guide
  • For visual design changes, pinged one of @ HYPD, @ mirualves, @ sarahill, or @ ry5n to update the Polaris UI kit

@kyledurand kyledurand force-pushed the collapsible_add-transition-properties branch from 341abff to 38bbee7 Compare March 13, 2020 15:11
@github-actions
Copy link
Contributor

github-actions bot commented Mar 13, 2020

🟡 This pull request modifies 4 files and might impact 5 other files. This is an average splash zone for a change, remember to tophat areas that could be affected.

Details:
All files potentially affected (total: 5)
📄 UNRELEASED.md (total: 0)

Files potentially affected (total: 0)

🧩 src/components/Collapsible/Collapsible.tsx (total: 5)

Files potentially affected (total: 5)

📄 src/components/Collapsible/README.md (total: 0)

Files potentially affected (total: 0)

🧩 src/components/Collapsible/tests/Collapsible.test.tsx (total: 0)

Files potentially affected (total: 0)

@kyledurand kyledurand force-pushed the collapsible_add-transition-properties branch from 38bbee7 to 5a8ad65 Compare March 13, 2020 15:22
@kyledurand kyledurand merged commit 252066b into master Mar 13, 2020
@kyledurand kyledurand deleted the collapsible_add-transition-properties branch March 13, 2020 18:04
athornburg pushed a commit to athornburg/polaris-react that referenced this pull request Apr 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants