Skip to content

[ResourceList] refactor to functional component #2843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Jun 8, 2020
Merged

[ResourceList] refactor to functional component #2843

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
d0698ad
Refactor resource list to a functional component
athornburg Mar 18, 2020
b1bf35e
Add link to issue number
athornburg Apr 20, 2020
bd79c12
Add link to issue number
athornburg Apr 20, 2020
8d7ef25
Infer the types of items on ResourceList tests
athornburg Apr 20, 2020
23f5269
Moved a few functions out of the ResourceList component
athornburg Apr 20, 2020
c2a060a
Move default id for item function definition
athornburg Apr 20, 2020
49be397
move default id for item out of the component
athornburg Apr 20, 2020
6c79289
Add a few more generics to functions that interact on items
athornburg Apr 21, 2020
f08bad9
Fix sticky header
May 8, 2020
18681aa
Fix the tests
athornburg May 9, 2020
3ab046c
Return StickyHeader function
athornburg May 9, 2020
f519a48
Force an update when listRef changes
athornburg May 9, 2020
3c89d94
inline the sticky header stuff
athornburg May 9, 2020
ff43297
small refactor on the force update reducer
athornburg May 9, 2020
c9ab2b8
Fixed the types on the force update reducer
athornburg May 9, 2020
7578ec5
Fix types on force update
athornburg May 9, 2020
2128b64
Fix Unreleased
athornburg Jun 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions UNRELEASED.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,8 @@

### Enhancements

- Added `ReactNode` as an accepted prop type to `primaryAction` on the `Page` component ([#3002](https://github.com/Shopify/polaris-react/pull/3002))
- Added a `fullWidth` prop to `EmptyState` to support full width layout within a content context ([#2992](https://github.com/Shopify/polaris-react/pull/2992))
- Added an `emptyState` prop to `ResourceList` to support in context empty states in list views ([#2569](https://github.com/Shopify/polaris-react/pull/2569))
Set `active` prop of `Popover` to true on keyDown in `ComboBox` to fix `Autocomplete` suggestions not showing when searching and selecting via keyboard ([#3028](https://github.com/Shopify/polaris-react/pull/3028))
- Changed Resource List to a generic functional component ([#2843](https://github.com/Shopify/polaris-react/pull/2843))
- Made the `renderItem` function infer the type of the items prop ([#2843](https://github.com/Shopify/polaris-react/pull/2843))

### Bug fixes

Expand Down
Loading