Skip to content

Conversation

davidpgero
Copy link
Contributor

This PR fixes two typo errors in the Form documentation string.

WHY are these changes introduced?

There were two typo errors. It's better to fix them.

WHAT is this pull request doing?

image

@ghost
Copy link

ghost commented Mar 30, 2020

👋 Thanks for opening your first pull request. A contributor should give feedback soon. If you haven’t already, please check out the contributing guidelines.

@ghost ghost added the cla-needed Added by a bot. Contributor needs to sign the CLA Agreement. label Mar 30, 2020
- browser
- submitting
@davidpgero davidpgero force-pushed the dg/typo-fix-on-form branch from 1cabf89 to e860997 Compare March 30, 2020 15:27
@ghost ghost removed the cla-needed Added by a bot. Contributor needs to sign the CLA Agreement. label Mar 30, 2020
Copy link
Contributor

@kaelig kaelig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution, @davidpgero ❤️

Co-Authored-By: Kaelig Deloumeau-Prigent <kaelig@users.noreply.github.com>
@davidpgero
Copy link
Contributor Author

There are three checks required.

I'm not sure who I can run them.

  • Shrink-Ray: Net Diff
  • Travis CI - Branch
  • percy/polaris-react

@kaelig
Copy link
Contributor

kaelig commented Apr 3, 2020

No worries, I'll just merge this PR despite the failing checks, since it doesn't touch code.

@kaelig kaelig merged commit fb18360 into Shopify:master Apr 3, 2020
@ghost
Copy link

ghost commented Apr 3, 2020

🎉 Thanks for your contribution to Polaris React!

athornburg pushed a commit to athornburg/polaris-react that referenced this pull request Apr 15, 2020
* Fix two typos

- browser
- submitting

* Update UNRELEASED.md

Co-Authored-By: Kaelig Deloumeau-Prigent <kaelig@users.noreply.github.com>

Co-authored-by: Kaelig Deloumeau-Prigent <kaelig@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants