Skip to content

Conversation

@alex-page
Copy link
Member

@alex-page alex-page commented Apr 3, 2020

WHY are these changes introduced?

Fixes deployment automation for automatic PR in styleguide and web.

WHAT is this pull request doing?

How to TopHat this change

  1. Create a new branch off this one
  2. Run yarn version and increase the version by an -alpha.1
  3. git push origin polaris-release --follow-tags
  4. Create a new stack in ShipIt pointed at that branch
  5. Deploy the release on Ship It
  6. A pull request should be made on web and styleguide

I tophatted this change by making a branch off this and a new ShipIt stack. It generated these two PR's https://github.com/Shopify/web/pull/26031 https://github.com/Shopify/polaris-styleguide/pull/3333

Screen Shot 2020-04-16 at 4 42 56 PM

Screen Shot 2020-04-16 at 4 44 22 PM

@alex-page alex-page self-assigned this Apr 3, 2020
@alex-page alex-page changed the title Moved access_token from CURL POST url to -H Fix PR creation in web and styleguide when releasing Apr 3, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Apr 3, 2020

🟢 No significant changes to src/**/*.tsx were detected.

@alex-page alex-page added 🤖Skip Changelog Causes CI to ignore changelog update check. and removed 🤖Skip Changelog Causes CI to ignore changelog update check. labels Apr 3, 2020
@alex-page alex-page marked this pull request as ready for review April 16, 2020 20:16
@alex-page alex-page requested review from BPScott and amrocha April 16, 2020 20:16
Copy link
Member

@BPScott BPScott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Co-Authored-By: Daniel Leroux <dleroux@users.noreply.github.com>
@alex-page alex-page merged commit c1dee81 into master Apr 17, 2020
@alex-page alex-page deleted the pr-generator-api-change branch April 17, 2020 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants