Fix unexpected module shaking issues #2897
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-page
approved these changes
Apr 6, 2020
athornburg
pushed a commit
to athornburg/polaris-react
that referenced
this pull request
Apr 15, 2020
Avoid using export * for types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Partial fix for #2896
Web needed some wrangling because we try to import empty files in esnext - this is because those files contained types but they all go stripped away during the build. Let's make sure we don't try to reference empty files so consuming apps complain about us doing so
WHAT is this pull request doing?
export *from a types-only file and that will result in the export not being elidedThat's just a band aid! what's the real fix?
We want to get this change out ASAP so we unblock other consumers from updating.
The long-term fix is to urn on
importsNotUsedAsValues: errorin tsconfig.json, which will force us to useimport type/export typewhen referring to types, which makes these import get elided.How to 🎩
Cut a beta release, and try and use it in web while deleting the sewing-kit.config.ts changes added in https://github.com/Shopify/web/pull/25448/files