Enable "importsNotUsedAsValues:error" TypeScript config #2901
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BPScott
force-pushed
the
ts-importsNotUsedAsValues
branch
from
c198568 to
e357175
Compare
Contributor
By ensuring we mark type-only imports we make sure that we avoid deoptimisations and export issues if compiled files reference empty files (which are empty because types have no compile time output)
BPScott
force-pushed
the
ts-importsNotUsedAsValues
branch
from
e357175 to
6f6df1b
Compare
alex-page
reviewed
Apr 9, 2020
alex-page
approved these changes
Apr 9, 2020
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Follow up to #2897
Fixes #2896
By ensuring we mark type-only imports we make sure that we avoid
deoptimisations and export issues if compiled files reference empty
files (which are empty because types have no compile time output)
WHAT is this pull request doing?
Sets
importsNotUsedAsValuestoerrorin our tsconfig and change anyimport {SomeType}references toimport type {SomeType}that it flags.How to 🎩
Ensure that type-check passes.
Ensure that the build output does not change, by doing the following:
git checkout 27842a6389d2ebd073463fa5f8f2d47dcdc3a035 && yarn build && mv esnext esnext-basegit checkout ts-importsNotUsedAsValues && yarn build && diff -ru esnext-base esnext