Skip to content

[ResourceList] Adjust sizing of CheckableButtonWrapper so it doesn't get squished #3010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

[ResourceList] Adjust sizing of CheckableButtonWrapper so it doesn't get squished #3010

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
68cd045
Adjust sizing of CheckableButtonWrapper so it doesn't get squished
amorriscode May 28, 2020
857173d
Add line to UNRELEASED.md
amorriscode May 28, 2020
674e500
Merge branch 'master' into resource-list/improve-styling
amorriscode Jun 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions UNRELEASED.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,9 @@

### Bug fixes

- Fixed incorrect `icon` color of `Button` when `destructive` and `plain` ([#2958](https://github.com/Shopify/polaris-react/issues/2958))
- Fixed sizing issue with `CheckableButtonWrapper` on `ResourceList` ([#2961](https://github.com/Shopify/polaris-react/issues/2961))
Comment on lines +20 to +21
Copy link
Member

@alex-page alex-page Jul 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Fixed incorrect `icon` color of `Button` when `destructive` and `plain` ([#2958](https://github.com/Shopify/polaris-react/issues/2958))
- Fixed sizing issue with `CheckableButtonWrapper` on `ResourceList` ([#2961](https://github.com/Shopify/polaris-react/issues/2961))
- Fixed sizing issue with `CheckableButtonWrapper` on `ResourceList` ([#2961](https://github.com/Shopify/polaris-react/issues/2961))


### Documentation

### Development workflow
Expand Down
13 changes: 13 additions & 0 deletions src/components/ResourceList/ResourceList.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,3 +240,16 @@ $item-wrapper-loading-height: rem(64px);
.disableTextSelection {
user-select: none;
}

.HeaderTitleWrapper,
.CheckableButtonWrapper,
.AlternateToolWrapper,
.SortWrapper,
.SelectButtonWrapper {
@include layout-flex-fix;
}
Comment on lines +244 to +250
Copy link
Member

@alex-page alex-page Jul 13, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these values needed? I assume you added them so the areas to the right collapse down?


.HeaderTitleWrapper,
.CheckableButtonWrapper {
min-width: spacing();
}