-
Notifications
You must be signed in to change notification settings - Fork 1.2k
[ResourceList] Adjust sizing of CheckableButtonWrapper so it doesn't get squished #3010
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ResourceList] Adjust sizing of CheckableButtonWrapper so it doesn't get squished #3010
Conversation
|
👋 Thanks for opening your first pull request. A contributor should give feedback soon. If you haven’t already, please check out the contributing guidelines. |
4eab9e5 to
9e09ba7
Compare
2c6e842 to
d2611d6
Compare
|
@alex-page just wondering if there is interest in this PR or if I should close it? |
| - Fixed incorrect `icon` color of `Button` when `destructive` and `plain` ([#2958](https://github.com/Shopify/polaris-react/issues/2958)) | ||
| - Fixed sizing issue with `CheckableButtonWrapper` on `ResourceList` ([#2961](https://github.com/Shopify/polaris-react/issues/2961)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| - Fixed incorrect `icon` color of `Button` when `destructive` and `plain` ([#2958](https://github.com/Shopify/polaris-react/issues/2958)) | |
| - Fixed sizing issue with `CheckableButtonWrapper` on `ResourceList` ([#2961](https://github.com/Shopify/polaris-react/issues/2961)) | |
| - Fixed sizing issue with `CheckableButtonWrapper` on `ResourceList` ([#2961](https://github.com/Shopify/polaris-react/issues/2961)) |
| .HeaderTitleWrapper, | ||
| .CheckableButtonWrapper, | ||
| .AlternateToolWrapper, | ||
| .SortWrapper, | ||
| .SelectButtonWrapper { | ||
| @include layout-flex-fix; | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these values needed? I assume you added them so the areas to the right collapse down?
|
If this is all in a flex container then I would imagine adding |
c630336 to
ea3c495
Compare
|
@amorriscode I am going to close this PR but please reopen it if it is still an issue. |
WHY are these changes introduced?
Fixes #2961
Following up on a previous PR, the
CheckableButtonwas being squished.WHAT is this pull request doing?
This PR adds
min-width: spacing();to theCheckableButtonWrapperso it has a nice amount of space.Before:
After:
How to 🎩
🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines
Copy-paste this code in
playground/Playground.tsx:🎩 checklist
README.mdwith documentation changes