Skip to content

Conversation

@alex-page
Copy link
Member

@alex-page alex-page commented Nov 9, 2020

WHY are these changes introduced?

Should be merged after #3609 and fixes #3438

search-alignment

WHAT is this pull request doing?

  • Make sure the TopBar search aligns with the Page content when it is not fullWidth
  • No deprecations to Contextual save bar alignment
  • Does not break additional navigation or user menu layout

How to 🎩

🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines

  1. Go to the details page and remove the fullwidth property
  2. Open the details page in a browser and the Page contents should line up with the search at all break points above mobile.
  3. Make sure the contextual save bar also lines up with the page
  4. Add a secondary navigation and make sure it lines up with the page
Copy-paste this code in playground/Playground.tsx:
import React from 'react';
import {Page} from '../src';

export function Playground() {
  return (
    <Page title="Playground">
      {/* Add the code you want to test in here */}
    </Page>
  );
}

🎩 checklist

  • Tested on mobile
  • Tested on multiple browsers
  • Tested for accessibility
  • Updated the component's README.md with documentation changes
  • Tophatted documentation changes in the style guide
  • For visual design changes, pinged one of @ HYPD, @ mirualves, @ sarahill, or @ ry5n to update the Polaris UI kit

@github-actions
Copy link
Contributor

github-actions bot commented Nov 9, 2020

🟢 This pull request modifies 2 files and might impact 1 other files.

Details:
All files potentially affected (total: 1)
📄 UNRELEASED.md (total: 0)

Files potentially affected (total: 0)

🎨 src/components/TopBar/TopBar.scss (total: 1)

Files potentially affected (total: 1)

$icon-size: rem(20px);
$page-left-alignment-breakpoint-max: 1268px;
$context-control-extra-spacing: rem(40px);
$page-left-alignment-breakpoint-max: 1238px;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Magic number continues ✨

Copy link
Member

@kyledurand kyledurand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎩 looks good

@alex-page alex-page merged commit b2ab7ae into master Nov 11, 2020
@alex-page alex-page deleted the search-alignment branch November 11, 2020 18:44
sylvhama pushed a commit that referenced this pull request Mar 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Adjust search location to align with page content

3 participants