Remove 10px padding on details page #3609
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
🟢 No significant changes to |
9 tasks
Member
|
Would a better fix be updating the "toggle fullscreen" logic at polaris-react/.storybook/polaris-readme-loader.js Lines 39 to 41 in 6f0cfe9 |
amrocha
reviewed
Nov 9, 2020
Contributor
|
@BPScott Ben get out of here you're on vacation we got this |
amrocha
approved these changes
Nov 9, 2020
Member
Author
kaelig
approved these changes
Nov 10, 2020
Contributor
kaelig
left a comment
kaelig
left a comment
There was a problem hiding this comment.
Makes total sense! 
Removing the
stupidadded 10px from storybook.
🤔👎
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
When trying to work on #3438, the details page has a 10px padding added by storybook. This adds an unnecessary speed bump to replicating production pages.
WHAT is this pull request doing?
Removing the stupid added 10px from storybook.