Format a11y error messages and remove skip #3721
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-page
force-pushed
the
remove-a11y-error-bypass
branch
from
54c72ad to
666bc5f
Compare
Contributor
|
🟢 No significant changes to |
alex-page
force-pushed
the
remove-a11y-error-bypass
branch
from
666bc5f to
d8dfac0
Compare
alex-page
commented
Dec 16, 2020
Comment on lines
34
to
36
| `${idParam}&contexts=Global%20Theming=Enabled%20-%20Light%20Mode`, | ||
| // Dark mode has lots of errors. It is still very WIP so ignore for now | ||
| // `${idParam}&contexts=Global%20Theming=Enabled%20-%20Dark%20Mode`, |
Member
Author
There was a problem hiding this comment.
These links were not correctly resolving the New Design Language.
alex-page
commented
Dec 16, 2020
Comment on lines
61
to
72
| return Promise.resolve({ | ||
| type: 'FAIL', | ||
| url, | ||
| errorCount: result.violations.length, | ||
| error: JSON.stringify(result.violations, null, 2), | ||
| }); | ||
| } catch (error) { | ||
| return Promise.resolve({ | ||
| type: 'ERROR', | ||
| url, | ||
| error: JSON.stringify(error, null, 2), | ||
| }); |
Member
Author
There was a problem hiding this comment.
We don't need to resolve a promise inside p-map as it is already an async function which returns a promise. Removing the different types as the user only needs to know if there is an error caught or if the a11y tests failed.
alex-page
commented
Dec 16, 2020
scripts/accessibility-check.js
Outdated
| const isSkippedStory = | ||
| story.kind === 'Playground/Playground' || story.name === 'All Examples'; | ||
| const formatMessage = (id, violations) => { | ||
| const url = chalk.underline.blue(`http://localhost:6006/iframe.html?id=all-components-${id}`); |
Member
Author
There was a problem hiding this comment.
Added the URL for finding issues quickly, might be a bit too much information.
alex-page
commented
Dec 16, 2020
alex-page
changed the title
alex-page
force-pushed
the
remove-a11y-error-bypass
branch
from
b63a0ee to
a4e74ac
Compare
alex-page
force-pushed
the
remove-a11y-error-bypass
branch
from
fec5fd6 to
3e42326
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fixes #0000
WHAT is this pull request doing?
How to 🎩
🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines
Copy-paste this code in
playground/Playground.tsx:🎩 checklist
README.mdwith documentation changes