Skip to content

[Popover] center full width popovers on small viewports #4114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 3, 2021
Merged

[Popover] center full width popovers on small viewports #4114

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7c571f7
center full width popovers on small viewports
Apr 9, 2021
8fda4ff
use four values for margin shorthand
Dec 3, 2021
8bb6f26
update UNRELEASED.md
Dec 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions UNRELEASED.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ Use [the changelog guidelines](/documentation/Versioning%20and%20changelog.md) t

### Bug fixes

- Centered full width `Popover` on small viewports ([#4114](https://github.com/Shopify/polaris-react/pull/4114))

### Documentation

### Development workflow
Expand Down
5 changes: 2 additions & 3 deletions src/components/Popover/Popover.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,7 @@ $vertical-motion-offset: rem(-5px);
}

.fullWidth {
margin: 0;
margin-top: $visible-portion-of-arrow;
margin: $visible-portion-of-arrow auto 0 auto;

.Content {
max-width: none;
Expand All @@ -54,7 +53,7 @@ $vertical-motion-offset: rem(-5px);
margin: spacing() spacing(tight) $visible-portion-of-arrow;

&.fullWidth {
margin: 0 0 $visible-portion-of-arrow;
margin: 0 auto $visible-portion-of-arrow auto;
}
}

Expand Down