[DropZone] Add prop to DropZone so children control its height #4136
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Right now,
DropZonehas 4 sizes:small,medium,large, andextraLarge. These are calculated based on the width of theDropZone. These sizes determine themin-heightof the component. This means you cannot have aDropZonethat is narrower than the set height at a given size.We have a case where we need the height to be narrower than what is automatically set by this component.
I've opened an issue about making this the default behaviour.
WHAT is this pull request doing?
This PR adds a prop
variableHeightthat skips the size calculation and makes theDropZone's height dependent on its children instead.How to 🎩
🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines
View the new "Drop zone with variable size" story in Storybook.
or
Copy-paste this code in
playground/Playground.tsx:🎩 checklist
README.mdwith documentation changes