Skip to content

Conversation

@alexandcote
Copy link
Contributor

@alexandcote alexandcote commented Apr 29, 2021

WHY are these changes introduced?

The color picker had a fixed width and some UI we have to build needs a slightly larger picker.

WHAT is this pull request doing?

Splitting the Picker size with width and height and adding the new fullWidth prop which tweaks some CSS.

How to 🎩

🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines

You can 🎩 on the storybook I added a new story.

🎩 checklist

  • Tested on mobile
  • Tested on multiple browsers
  • Tested for accessibility
  • Updated the component's README.md with documentation changes
  • Tophatted documentation changes in the style guide
  • For visual design changes, pinged one of @ HYPD, @ mirualves, @ sarahill, or @ ry5n to update the Polaris UI kit

@alexandcote alexandcote force-pushed the color-picker-full-width branch from 5bc396f to f77d53a Compare April 29, 2021 19:58
@github-actions
Copy link
Contributor

github-actions bot commented Apr 29, 2021

🟢 This pull request modifies 4 files and might impact 1 other files.

Details:
All files potentially affected (total: 1)
📄 UNRELEASED.md (total: 0)

Files potentially affected (total: 0)

🎨 src/components/ColorPicker/ColorPicker.scss (total: 1)

Files potentially affected (total: 1)

🧩 src/components/ColorPicker/ColorPicker.tsx (total: 0)

Files potentially affected (total: 0)

📄 src/components/ColorPicker/README.md (total: 0)

Files potentially affected (total: 0)

@alexandcote alexandcote marked this pull request as ready for review April 29, 2021 20:01
@alexandcote alexandcote self-assigned this Apr 29, 2021
Copy link
Member

@alex-page alex-page left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice PR thanks for making this more flexible.

Copy link
Member

@kyledurand kyledurand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thanks @alexandcote

@kyledurand kyledurand merged commit 327d962 into main Apr 30, 2021
@kyledurand kyledurand deleted the color-picker-full-width branch April 30, 2021 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants