Skip to content

Conversation

@brydonm
Copy link
Contributor

@brydonm brydonm commented Aug 4, 2021

WHY are these changes introduced?

Fixes #4358

Unselected hover state had a blue hue where it should be grey

WHAT is this pull request doing?

Fixes the unselected hover state color and selected hover state color

@ghost
Copy link

ghost commented Aug 4, 2021

👋 Thanks for opening your first pull request. A contributor should give feedback soon. If you haven’t already, please check out the contributing guidelines.

@ghost ghost added the cla-needed Added by a bot. Contributor needs to sign the CLA Agreement. label Aug 4, 2021
@brydonm brydonm force-pushed the 4358/adjust-indextable-row-unselected-hover-state-color branch from 7e01862 to e5adcc1 Compare August 4, 2021 18:42
@brydonm brydonm changed the title [IndexTable] Adjust indextable row unselected hover state color [IndexTable] Adjust row unselected hover state color and selected hover state color Aug 4, 2021
@brydonm brydonm force-pushed the 4358/adjust-indextable-row-unselected-hover-state-color branch from e5adcc1 to bd7bd96 Compare August 4, 2021 19:06
@ghost ghost removed the cla-needed Added by a bot. Contributor needs to sign the CLA Agreement. label Aug 4, 2021
@alex-page alex-page merged commit e939476 into Shopify:main Aug 5, 2021
@ghost
Copy link

ghost commented Aug 5, 2021

🎉 Thanks for your contribution to Polaris React!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect hover color for IndexTable rows

2 participants