Skip to content

[IndexTable] Adjust row unselected hover state color and selected hover state color #4359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 5, 2021
Merged

[IndexTable] Adjust row unselected hover state color and selected hover state color #4359

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions UNRELEASED.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ Use [the changelog guidelines](https://git.io/polaris-changelog-guidelines) to f
- Fix bug in Safari where `Button` text is gray instead of white after changing state from disabled to enabled ([#4270](https://github.com/Shopify/polaris-react/pull/4270))
- Bring back borders on the `IndexTable` sticky cells ([#4150](https://github.com/Shopify/polaris-react/pull/4150))
- Adjust `IndexTable` sticky z-index to avoid collisions with focused `TextField` ([#4150](https://github.com/Shopify/polaris-react/pull/4150))
- Adjust `IndexTable` rows to have a grey hover state when unselected ([#4359](https://github.com/Shopify/polaris-react/pull/4359))

### Documentation

Expand Down
11 changes: 10 additions & 1 deletion src/components/IndexTable/IndexTable.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ $loading-panel-height: rem(53px);
&,
.TableCell-first,
.TableCell-first + .TableCell {
background-color: var(--p-surface-selected-hovered);
background-color: var(--p-surface-hovered);
}
}

Expand All @@ -147,6 +147,15 @@ $loading-panel-height: rem(53px);
background-color: var(--p-surface-selected);
}
}

&.TableRow-hovered.TableRow-selected {
// stylelint-disable-next-line selector-max-class, selector-max-combinators, selector-max-specificity
&,
.TableCell-first,
.TableCell-first + .TableCell {
background-color: var(--p-surface-selected-hovered);
}
}
}

.TableRow-subdued {
Expand Down