-
Notifications
You must be signed in to change notification settings - Fork 1.2k
[MediaCard] Remove extraneous space when card has no actions #4538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
kyledurand
merged 8 commits into
Shopify:main
from
emilycritter:fix/media-card-extraneous-space
Nov 3, 2021
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
03b11c5
Remove extraneous space from MediaCard when no actions
emilycritter 3dc616d
Add bug to UNRELEASED instead of CHANGELOG
emilycritter 8b3457f
Remove entry from CHANGELOG
emilycritter aa0aa5e
Adds example to README for MediaCard without actions
emilycritter 3b10c53
Merge branch 'main' into fix/media-card-extraneous-space
kaelig 1ab4d34
Add period to example description
kaelig d23a51d
Fix condition and formatting
kaelig f729d60
Add test to check that the wrapper around actions only renders when e…
kaelig File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -211,6 +211,26 @@ Use when there are two distinct actions merchants can take on the information in | |
| </MediaCard> | ||
| ``` | ||
|
|
||
| ### Media card with no actions | ||
|
|
||
| Use when media card does not require any actions. | ||
|
|
||
| ```jsx | ||
| <MediaCard | ||
| title="Getting Started" | ||
| description="Discover how Shopify can power up your entrepreneurial journey." | ||
|
Comment on lines
+220
to
+221
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This content wouldn't be something we'd want without a call to action, but that's something that can be addressed separately. |
||
| popoverActions={[{content: 'Dismiss', onAction: () => {}}]} | ||
| > | ||
| <img | ||
| alt="" | ||
| width="100%" | ||
| height="100%" | ||
| style={{objectFit: 'cover', objectPosition: 'center'}} | ||
| src="https://burst.shopifycdn.com/photos/business-woman-smiling-in-office.jpg?width=1850" | ||
| /> | ||
| </MediaCard> | ||
| ``` | ||
|
|
||
| ### Video card | ||
|
|
||
| Use to provide a consistent layout for contextual learning content. Use to wrap thumbnails of educational videos about Shopify features in context. | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we had codecov still active it would complain about not adding tests for this and we don't have visual regression testing at the moment so I think it worth adding a couple of tests here. I think we can just test to make sure button group doesn't render if primary or secondary actions are passed in
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good! I added a simple test in f729d60