[ActionList] remove vertical padding from wrapping div #4571
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Thanks for opening your first pull request. A contributor should give feedback soon. If you haven’t already, please check out the contributing guidelines. |
Contributor
size-limit report
|
mattkubej
force-pushed
the
4570-action-list-padding
branch
from
42f19b4 to
fbf418c
Compare
Contributor
Author
|
We did a quick triage and found that the only component that does not use ActionList within a Popover is “Crop and rotate” As highlighted here: |
dfmcphee
approved these changes
Nov 9, 2021
mattkubej
force-pushed
the
4570-action-list-padding
branch
from
fbf418c to
edd936b
Compare
|
🎉 Thanks for your contribution to Polaris React! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Addresses: #4570
Removes the vertical padding of the
<ActionList />to provide a more compact aesthetic.WHAT is this pull request doing?
Removes padding attribute from the top-level element of
<ActionList />.Horizontal padding was set to 0 and only the vertical padding was set. So, I removed the padding attribute, so we have no padding set.
Before
After
