[Button] Clean up Button styling and $button-filled mixin #4635
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Thanks for opening your first pull request. A contributor should give feedback soon. If you haven’t already, please check out the contributing guidelines. |
yurm04
commented
Nov 12, 2021
| color: var(--p-text-disabled); | ||
| } | ||
|
|
||
| @mixin button-filled($button-color, $focus-color, $outline-color: null) { |
Contributor
Author
There was a problem hiding this comment.
these parameters aren't being used anywhere, removing
Contributor
size-limit report
|
yurm04
changed the title
yurm04
pushed a commit
that referenced
this pull request
Nov 12, 2021
|
🎉 Thanks for your contribution to Polaris React! |
yurm04
pushed a commit
that referenced
this pull request
Nov 16, 2021
* removing all color() references * reverting button component changes because they're being addressed in #4635 * updating changelog * hardcoding background color value in app provider * removing color-icon sass function because not in use * adding stylelint disable line because we have to hardcode a value * revert remove color-icon function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While working through #4592 I found the
$button-filledmixin had some parameters that weren't being used. Decided to clean up the mixin and simplify theButtonstyle by creating a joint.primary, .destructivestyle.co-authored with @alex-page