Skip to content

Conversation

@alex-page
Copy link
Member

@alex-page alex-page commented Dec 9, 2021

WHY are these changes introduced?

Fixes #4910 and fixes #4980

WHAT is this pull request doing?

How to 🎩

🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines

Copy-paste this code in playground/Playground.tsx:
import React from 'react';
import {Page} from '../src';

export function Playground() {
  return (
    <Page title="Playground">
      {/* Add the code you want to test in here */}
    </Page>
  );
}

🎩 checklist

alex-page and others added 30 commits November 22, 2021 07:47
* Add font-weight tokens

* Replace font-weight: 400 with token

* Replace font-weight: 500 with token

* Replace font-weight: 600 with token

* Replace font-weight: 700 with token

* Update UNRELEASED.md

* Fix formatting of UNRELEASED

* Remove reverted entries in UNRELEASED

* Regenerate colordocs

* Remove duplicate entry in UNRELEASED

Co-authored-by: Alex Page <hi@alexpage.dev>
* Revert revert to remove misc tokens

* Update UNRELEASED.md

* Regenerate colordocs
* Remove sass filter function file

* Remove sass filter function imports

* Remove last instance of filter function

* Update UNRELEASED.md

* Fix UNRELEASED formatting

Co-authored-by: Alex Page <hi@alexpage.dev>
* Remove skeleton motion and skeleton-shimmer
* Remove tokens

* Remove unnecessary properties TextField

Co-Authored-By: Kyle Durand <6844391+kyledurand@users.noreply.github.com>

* Update UNRELEASED.md

Co-authored-by: Kyle Durand <6844391+kyledurand@users.noreply.github.com>
Co-authored-by: Ben Scott <227292+BPScott@users.noreply.github.com>
* Move logo from ThemeProvider to Frame

* Remove unused eslint disable

* Update test name to reflect dark scheme

* Update src/components/Frame/Frame.tsx

Co-authored-by: Aaron Casanova <32409546+aaronccasanova@users.noreply.github.com>

* re-word topbar test

Co-authored-by: Aaron Casanova <32409546+aaronccasanova@users.noreply.github.com>
aveline and others added 21 commits February 10, 2022 09:04
* Update migrating-from-v8-to-v9.md

* Populate link to px() definition

* Add migration guidance for px()

* Update permalink to highlight range
* Adding migration documentation for the skeletonpage component

* Running prettier

* Update documentation/guides/migrating-from-v8-to-v9.md

Co-authored-by: Aaron Casanova <32409546+aaronccasanova@users.noreply.github.com>

Co-authored-by: Aaron Casanova <32409546+aaronccasanova@users.noreply.github.com>
* Add in all color function and mixin headers

* Move color() UNRELEASED entry to v9 doc

* Add documentation for color functions and mixins

* Wording and presentation revisions

* Link out section references

* Fix typo

* Add clarification to documentation
* zindex migration guidance

* Fix z-index tokens

* Add devUi value for z-index function
…()`, `when-not-printing()`, `when-printing()` functions (#5120)

* Add documentation for hidden-when-printing, print-hidden, when-not-printing, when-printing functions

* Update documentation/guides/migrating-from-v8-to-v9.md

Co-authored-by: Laura Griffee <laura@mailzone.com>

* Update documentation/guides/migrating-from-v8-to-v9.md

Co-authored-by: Laura Griffee <laura@mailzone.com>

Co-authored-by: Laura Griffee <laura@mailzone.com>
* Add documentation for icon-size() function

* Running prettier
…de (#5137)

* Consolidate css custom properties into one table

* Minor language tweak
* Add documentation for skeleton-page-header-layout() mixin

* Add documentation for skeleton-page-secondary-actions-layout() mixin

* Create documentation for skeleton-shimmer() mixin

* Remove extra semicolon
Update Navigation spacing and stories to match main
* Create documentation for available-names()

* Link to function definition in mega file

* Update table header language
* Create documentation for state() mixin

* Remove secondary table option

* Remove unnecessary style declaration
* Add migration guidance for `polaris-tokens`

* Update polaris-tokens deprecation language
* Clarify language

* Minor noun casing adjustments to migration guide

* Minor language tweak

Co-authored-by: Sam Rose <sam.rose@shopify.com>
* Add documentation for sass global variables

* Consolidate table

* Fix casing

* Fix the right casing
@sam-b-rose sam-b-rose requested review from sam-b-rose and removed request for sam-b-rose February 14, 2022 18:19
lgriffee and others added 2 commits February 14, 2022 11:21
* Add existing headers to table of contents

* Add new merges

* Remove unwanted headers from table of contents

* Remove plugin comments
@sam-b-rose sam-b-rose merged commit e11f52f into main Feb 15, 2022
Comment on lines +6 to +10
font-size: 24px;
line-height: 28px;

@include when-typography-not-condensed {
font-size: rem(20px);
font-size: 20px;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alex-page Random late question since I noticed this while looking into some typography stuff. Is there a reason this isn't using the typography tokens?

Feel free to ignore me if so, but it seemed odd since everything else I looked at seems to be.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are going to back through the values and update them to use tokens now. Thanks for noticing this one!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove public scss api Polaris v9

9 participants