-
Notifications
You must be signed in to change notification settings - Fork 1.2k
v9.0.0 #4821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v9.0.0 #4821
Conversation
ZIndex = z-index
* Add font-weight tokens * Replace font-weight: 400 with token * Replace font-weight: 500 with token * Replace font-weight: 600 with token * Replace font-weight: 700 with token * Update UNRELEASED.md * Fix formatting of UNRELEASED * Remove reverted entries in UNRELEASED * Regenerate colordocs * Remove duplicate entry in UNRELEASED Co-authored-by: Alex Page <hi@alexpage.dev>
* Revert revert to remove misc tokens * Update UNRELEASED.md * Regenerate colordocs
* Remove sass filter function file * Remove sass filter function imports * Remove last instance of filter function * Update UNRELEASED.md * Fix UNRELEASED formatting Co-authored-by: Alex Page <hi@alexpage.dev>
* Remove skeleton motion and skeleton-shimmer
* Remove tokens * Remove unnecessary properties TextField Co-Authored-By: Kyle Durand <6844391+kyledurand@users.noreply.github.com> * Update UNRELEASED.md Co-authored-by: Kyle Durand <6844391+kyledurand@users.noreply.github.com>
Co-authored-by: Ben Scott <227292+BPScott@users.noreply.github.com>
* Move logo from ThemeProvider to Frame * Remove unused eslint disable * Update test name to reflect dark scheme * Update src/components/Frame/Frame.tsx Co-authored-by: Aaron Casanova <32409546+aaronccasanova@users.noreply.github.com> * re-word topbar test Co-authored-by: Aaron Casanova <32409546+aaronccasanova@users.noreply.github.com>
* Adding migration documentation for the skeletonpage component * Running prettier * Update documentation/guides/migrating-from-v8-to-v9.md Co-authored-by: Aaron Casanova <32409546+aaronccasanova@users.noreply.github.com> Co-authored-by: Aaron Casanova <32409546+aaronccasanova@users.noreply.github.com>
* Add in all color function and mixin headers * Move color() UNRELEASED entry to v9 doc * Add documentation for color functions and mixins * Wording and presentation revisions * Link out section references * Fix typo * Add clarification to documentation
* zindex migration guidance * Fix z-index tokens * Add devUi value for z-index function
…()`, `when-not-printing()`, `when-printing()` functions (#5120) * Add documentation for hidden-when-printing, print-hidden, when-not-printing, when-printing functions * Update documentation/guides/migrating-from-v8-to-v9.md Co-authored-by: Laura Griffee <laura@mailzone.com> * Update documentation/guides/migrating-from-v8-to-v9.md Co-authored-by: Laura Griffee <laura@mailzone.com> Co-authored-by: Laura Griffee <laura@mailzone.com>
* Add documentation for icon-size() function * Running prettier
…de (#5137) * Consolidate css custom properties into one table * Minor language tweak
* Add documentation for skeleton-page-header-layout() mixin * Add documentation for skeleton-page-secondary-actions-layout() mixin * Create documentation for skeleton-shimmer() mixin * Remove extra semicolon
Update Navigation spacing and stories to match main
* Create documentation for available-names() * Link to function definition in mega file * Update table header language
* Add migration guidance for `polaris-tokens` * Update polaris-tokens deprecation language
* Clarify language * Minor noun casing adjustments to migration guide * Minor language tweak Co-authored-by: Sam Rose <sam.rose@shopify.com>
* Add documentation for sass global variables * Consolidate table * Fix casing * Fix the right casing
* Add existing headers to table of contents * Add new merges * Remove unwanted headers from table of contents * Remove plugin comments
| font-size: 24px; | ||
| line-height: 28px; | ||
|
|
||
| @include when-typography-not-condensed { | ||
| font-size: rem(20px); | ||
| font-size: 20px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alex-page Random late question since I noticed this while looking into some typography stuff. Is there a reason this isn't using the typography tokens?
Feel free to ignore me if so, but it seemed odd since everything else I looked at seems to be.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are going to back through the values and update them to use tokens now. Thanks for noticing this one!
WHY are these changes introduced?
Fixes #4910 and fixes #4980
WHAT is this pull request doing?
How to 🎩
🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines
Copy-paste this code in
playground/Playground.tsx:🎩 checklist
README.mdwith documentation changes