Skip to content

feat: Remove @shopify/polaris-tokens dependency #4868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 7, 2022
Merged

feat: Remove @shopify/polaris-tokens dependency #4868

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1792b9f
feat: Remove @shopify/polaris-tokens dependency
aaronccasanova Jan 5, 2022
7a5aa93
fix: Remove extraneous .eslintignore entry
aaronccasanova Jan 5, 2022
8b0d1cd
docs: Update unreleased changelog
aaronccasanova Jan 5, 2022
6f78700
Merge branch 'v9.0.0-major' of https://github.com/Shopify/polaris-rea…
aaronccasanova Jan 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .eslintignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,3 @@ node_modules
/examples
/build
/build-internal
/src/styles/polaris-tokens
2 changes: 2 additions & 0 deletions UNRELEASED-v8.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,8 @@ Use [the changelog guidelines](/documentation/Versioning%20and%20changelog.md) t

### Dependency upgrades

- Removed `@shopify/polaris-tokens` dependency ([#4868](https://github.com/Shopify/polaris-react/pull/4868))

### Code quality

- Replaced font-weight values with tokens ([#4599](https://github.com/Shopify/polaris-react/issues/4599))
Expand Down
1 change: 0 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,6 @@
},
"dependencies": {
"@shopify/polaris-icons": "^4.11.0",
"@shopify/polaris-tokens": "^3.0.0",
Copy link
Member Author

@aaronccasanova aaronccasanova Jan 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was expecting to see yarn.lock updates in addition to this line being removed.

Note: I am in the process of investigating the following error after running:
yarn remove @shopify/polaris-react
Screen Shot 2022-01-05 at 2 36 44 PM

Copy link
Member

@BPScott BPScott Jan 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

puppeteer/puppeteer#6622 (comment)

Seems updating puppeteer to a newer version should help. The dependency comes in from @shopify/storybook-a11y-test which was updated to use puppeteer@^10.4.0 several months ago in Shopify/quilt#2045.

Seems like updating to the latest version of @shopify/storybook-a11y-test should help. I expect you'd want to do that on the main branch

Copy link
Member Author

@aaronccasanova aaronccasanova Jan 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense 👍 I put together a PR in the main branch with these changes: #4870

Copy link
Member Author

@aaronccasanova aaronccasanova Jan 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merged the above PR into main, updated v8 and v9 branches, and merged v9 into this PR. Checks are passing now 🙌

"@types/react": "^17.0.19",
"@types/react-dom": "^17.0.9",
"@types/react-transition-group": "^4.4.2",
Expand Down