Skip to content

Conversation

@chazdean
Copy link
Contributor

@chazdean chazdean commented Dec 2, 2022

WHY are these changes introduced?

The SkeletonPage rebuild PR currently in progress is exceeding the size limit. This PR increases the size limit threshold from 216 kB to 220 kB to allow the size limit check to pass

@chazdean chazdean requested a review from laurkim December 2, 2022 15:22
Copy link
Contributor

@laurkim laurkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@chazdean chazdean merged commit 2e4d7ec into main Dec 2, 2022
@chazdean chazdean deleted the bump-size-limit branch December 2, 2022 15:27
juzser pushed a commit to juzser/polaris that referenced this pull request Jul 27, 2023
<!--
  ☝️How to write a good PR title:
- Prefix it with [ComponentName] (if applicable), for example: [Button]
  - Start with a verb, for example: Add, Delete, Improve, Fix…
  - Give as much context as necessary and as little as possible
  - Prefix it with [WIP] while it’s a work in progress
-->

### WHY are these changes introduced?

The `SkeletonPage` rebuild
[PR](Shopify#7797) currently in progress
is exceeding the size limit. This PR increases the size limit threshold
from `216 kB` to `220 kB` to allow the size limit check to pass

<!--
  Context about the problem that’s being addressed.
-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants