Skip to content

[Icon] Update clipboard icon to look like a clipboard #8148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 25, 2023
Merged

[Icon] Update clipboard icon to look like a clipboard #8148

merged 4 commits into from
Jan 25, 2023

Conversation

@zecarlostorre
Copy link
Contributor

@zecarlostorre zecarlostorre commented Jan 24, 2023

WHY are these changes introduced?

Current icon doesn't look like a clipboard, and sometimes is confused for a trashcan.

WHAT is this pull request doing?

Updating the icon:

image

@zecarlostorre zecarlostorre self-assigned this Jan 24, 2023
kyledurand
kyledurand approved these changes Jan 24, 2023
View reviewed changes
kyledurand
kyledurand reviewed Jan 24, 2023
View reviewed changes
@zecarlostorre @kyledurand
Update polaris-icons/icons/ClipboardMinor.svg
d22df89 
Co-authored-by: Kyle Durand <kyledurand@users.noreply.github.com>
sarahill
sarahill approved these changes Jan 24, 2023
View reviewed changes
Copy link
Contributor

@sarahill sarahill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

zecarlostorre and others added 2 commits January 25, 2023 10:36
@zecarlostorre @kyledurand
Update .changeset/wicked-moose-relax.md
3c2b98c 
Co-authored-by: Kyle Durand <kyledurand@users.noreply.github.com>
@zecarlostorre @kyledurand
Update polaris-icons/icons/ClipboardMinor.yml
38ba313 
Co-authored-by: Kyle Durand <kyledurand@users.noreply.github.com>
@zecarlostorre zecarlostorre merged commit 0ca0b78 into main Jan 25, 2023
@zecarlostorre zecarlostorre deleted the updated-clipboard-icon branch January 25, 2023 11:26
@shopify-github-actions-access shopify-github-actions-access bot mentioned this pull request Jan 25, 2023
Merged
yurm04 pushed a commit that referenced this pull request Jan 26, 2023
@shopify-github-actions-access @github-actions
Version Packages (#8147)
5597775 
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## @shopify/polaris-icons@6.10.0

### Minor Changes

- [#8150](#8150)
[`a0c6e467b`](a0c6e46)
Thanks [@leileu](https://github.com/leileu)! - Adding two metaobject
icons: Metaobject and Metaobject Reference.

### Patch Changes

- [#8148](#8148)
[`0ca0b7899`](0ca0b78)
Thanks [@zecarlostorre](https://github.com/zecarlostorre)! - Updated
clipboard icon

## @shopify/polaris@10.24.0

### Minor Changes

- [#8083](#8083)
[`18991daf1`](18991da)
Thanks [@krithikajanakiraman](https://github.com/krithikajanakiraman)! -
Adding an oprtional headerContent prop to ResourceList


- [#7821](#7821)
[`a0941743a`](a094174)
Thanks [@laurkim](https://github.com/laurkim)! - Rebuilt `ActionList` to
use layout primitives


- [#7821](#7821)
[`a0941743a`](a094174)
Thanks [@laurkim](https://github.com/laurkim)! - Refactored
`SkeletonPage` to use primitive Layout components
    Removed `max-width` on children in `AlphaStack`
    Added `narrowWidth` and `fullWidth` examples to `AlphaStack` stories

### Patch Changes

- [#7821](#7821)
[`a0941743a`](a094174)
Thanks [@laurkim](https://github.com/laurkim)! - Updated `SkeletonPage`
title and body layout


- [#7821](#7821)
[`a0941743a`](a094174)
Thanks [@laurkim](https://github.com/laurkim)! - Refactored
`SkeletonPage` title layout


- [#7821](#7821)
[`a0941743a`](a094174)
Thanks [@laurkim](https://github.com/laurkim)! - Fixed `ResourceList`
header alignment


- [#7821](#7821)
[`a0941743a`](a094174)
Thanks [@laurkim](https://github.com/laurkim)! - Rebuilt `ResourceItem`
with layout components


- [#7821](#7821)
[`a0941743a`](a094174)
Thanks [@laurkim](https://github.com/laurkim)! - Fixed IndexTable
checkbox alignment


- [#8099](#8099)
[`a3605c855`](a3605c8)
Thanks [@AndrewMusgrave](https://github.com/AndrewMusgrave)! - Fixed
`BulkActions` causing `IndexTable` & `ResourceList` to ignore pointer
events

- Updated dependencies
\[[`a0c6e467b`](a0c6e46),
[`0ca0b7899`](0ca0b78)]:
    -   @shopify/polaris-icons@6.10.0

## @shopify/plugin-polaris@0.0.31

### Patch Changes

-   Updated dependencies \[]:
    -   @shopify/polaris-migrator@0.11.2

## @shopify/polaris-migrator@0.11.2

### Patch Changes

- Updated dependencies
\[[`07669075a`](0766907),
[`74a75a473`](74a75a4),
[`f8f9eecd5`](f8f9eec)]:
    -   @shopify/stylelint-polaris@5.1.2

## @shopify/stylelint-polaris@5.1.2

### Patch Changes

- [#8167](#8167)
[`07669075a`](0766907)
Thanks [@aaronccasanova](https://github.com/aaronccasanova)! -
Temporarily disable layout category


- [#8162](#8162)
[`74a75a473`](74a75a4)
Thanks [@aaronccasanova](https://github.com/aaronccasanova)! - Allow
SCSS namespaces with Polaris breakpoints


- [#8168](#8168)
[`f8f9eecd5`](f8f9eec)
Thanks [@aaronccasanova](https://github.com/aaronccasanova)! - Ignored
needless disables for layout category and added meta URL to error
message

## polaris.shopify.com@0.30.1

### Patch Changes

- [#8123](#8123)
[`3bb6c03d3`](3bb6c03)
Thanks [@marlowpayne](https://github.com/marlowpayne)! - Improve
readability of markdown tables by wrapping on words


- [#8045](#8045)
[`b3ee45c47`](b3ee45c)
Thanks [@sarahill](https://github.com/sarahill)! - Added component
lifecycle page to polaris.shopify.com


- [#7821](#7821)
[`a0941743a`](a094174)
Thanks [@laurkim](https://github.com/laurkim)! - Rebuilt `ActionList` to
use layout primitives

- Updated dependencies
\[[`a0941743a`](a094174),
[`18991daf1`](18991da),
[`a0941743a`](a094174),
[`a0941743a`](a094174),
[`a0941743a`](a094174),
[`a0941743a`](a094174),
[`a0941743a`](a094174),
[`a0941743a`](a094174),
[`a0c6e467b`](a0c6e46),
[`a3605c855`](a3605c8),
[`0ca0b7899`](0ca0b78)]:
    -   @shopify/polaris@10.24.0
    -   @shopify/polaris-icons@6.10.0

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@gwyneplaine gwyneplaine mentioned this pull request Feb 14, 2023
Merged
juzser pushed a commit to juzser/polaris that referenced this pull request Jul 27, 2023
@zecarlostorre @kyledurand @juzser
[Icon] Update clipboard icon to look like a clipboard (Shopify#8148)
fcc5860 
### WHY are these changes introduced?

Current icon doesn't look like a clipboard, and sometimes is confused
for a trashcan.

### WHAT is this pull request doing?

Updating the icon:


![image](https://user-images.githubusercontent.com/55551051/214393271-8633946a-0019-452c-a3ae-c6e8fdd21c93.png)

Co-authored-by: Kyle Durand <kyledurand@users.noreply.github.com>
juzser pushed a commit to juzser/polaris that referenced this pull request Jul 27, 2023
@shopify-github-actions-access @github-actions @juzser
Version Packages (Shopify#8147)
2173048 
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## @shopify/polaris-icons@6.10.0

### Minor Changes

- [Shopify#8150](Shopify#8150)
[`a0c6e467b`](Shopify@a0c6e46)
Thanks [@leileu](https://github.com/leileu)! - Adding two metaobject
icons: Metaobject and Metaobject Reference.

### Patch Changes

- [Shopify#8148](Shopify#8148)
[`0ca0b7899`](Shopify@0ca0b78)
Thanks [@zecarlostorre](https://github.com/zecarlostorre)! - Updated
clipboard icon

## @shopify/polaris@10.24.0

### Minor Changes

- [Shopify#8083](Shopify#8083)
[`18991daf1`](Shopify@18991da)
Thanks [@krithikajanakiraman](https://github.com/krithikajanakiraman)! -
Adding an oprtional headerContent prop to ResourceList


- [Shopify#7821](Shopify#7821)
[`a0941743a`](Shopify@a094174)
Thanks [@laurkim](https://github.com/laurkim)! - Rebuilt `ActionList` to
use layout primitives


- [Shopify#7821](Shopify#7821)
[`a0941743a`](Shopify@a094174)
Thanks [@laurkim](https://github.com/laurkim)! - Refactored
`SkeletonPage` to use primitive Layout components
    Removed `max-width` on children in `AlphaStack`
    Added `narrowWidth` and `fullWidth` examples to `AlphaStack` stories

### Patch Changes

- [Shopify#7821](Shopify#7821)
[`a0941743a`](Shopify@a094174)
Thanks [@laurkim](https://github.com/laurkim)! - Updated `SkeletonPage`
title and body layout


- [Shopify#7821](Shopify#7821)
[`a0941743a`](Shopify@a094174)
Thanks [@laurkim](https://github.com/laurkim)! - Refactored
`SkeletonPage` title layout


- [Shopify#7821](Shopify#7821)
[`a0941743a`](Shopify@a094174)
Thanks [@laurkim](https://github.com/laurkim)! - Fixed `ResourceList`
header alignment


- [Shopify#7821](Shopify#7821)
[`a0941743a`](Shopify@a094174)
Thanks [@laurkim](https://github.com/laurkim)! - Rebuilt `ResourceItem`
with layout components


- [Shopify#7821](Shopify#7821)
[`a0941743a`](Shopify@a094174)
Thanks [@laurkim](https://github.com/laurkim)! - Fixed IndexTable
checkbox alignment


- [Shopify#8099](Shopify#8099)
[`a3605c855`](Shopify@a3605c8)
Thanks [@AndrewMusgrave](https://github.com/AndrewMusgrave)! - Fixed
`BulkActions` causing `IndexTable` & `ResourceList` to ignore pointer
events

- Updated dependencies
\[[`a0c6e467b`](Shopify@a0c6e46),
[`0ca0b7899`](Shopify@0ca0b78)]:
    -   @shopify/polaris-icons@6.10.0

## @shopify/plugin-polaris@0.0.31

### Patch Changes

-   Updated dependencies \[]:
    -   @shopify/polaris-migrator@0.11.2

## @shopify/polaris-migrator@0.11.2

### Patch Changes

- Updated dependencies
\[[`07669075a`](Shopify@0766907),
[`74a75a473`](Shopify@74a75a4),
[`f8f9eecd5`](Shopify@f8f9eec)]:
    -   @shopify/stylelint-polaris@5.1.2

## @shopify/stylelint-polaris@5.1.2

### Patch Changes

- [Shopify#8167](Shopify#8167)
[`07669075a`](Shopify@0766907)
Thanks [@aaronccasanova](https://github.com/aaronccasanova)! -
Temporarily disable layout category


- [Shopify#8162](Shopify#8162)
[`74a75a473`](Shopify@74a75a4)
Thanks [@aaronccasanova](https://github.com/aaronccasanova)! - Allow
SCSS namespaces with Polaris breakpoints


- [Shopify#8168](Shopify#8168)
[`f8f9eecd5`](Shopify@f8f9eec)
Thanks [@aaronccasanova](https://github.com/aaronccasanova)! - Ignored
needless disables for layout category and added meta URL to error
message

## polaris.shopify.com@0.30.1

### Patch Changes

- [Shopify#8123](Shopify#8123)
[`3bb6c03d3`](Shopify@3bb6c03)
Thanks [@marlowpayne](https://github.com/marlowpayne)! - Improve
readability of markdown tables by wrapping on words


- [Shopify#8045](Shopify#8045)
[`b3ee45c47`](Shopify@b3ee45c)
Thanks [@sarahill](https://github.com/sarahill)! - Added component
lifecycle page to polaris.shopify.com


- [Shopify#7821](Shopify#7821)
[`a0941743a`](Shopify@a094174)
Thanks [@laurkim](https://github.com/laurkim)! - Rebuilt `ActionList` to
use layout primitives

- Updated dependencies
\[[`a0941743a`](Shopify@a094174),
[`18991daf1`](Shopify@18991da),
[`a0941743a`](Shopify@a094174),
[`a0941743a`](Shopify@a094174),
[`a0941743a`](Shopify@a094174),
[`a0941743a`](Shopify@a094174),
[`a0941743a`](Shopify@a094174),
[`a0941743a`](Shopify@a094174),
[`a0c6e467b`](Shopify@a0c6e46),
[`a3605c855`](Shopify@a3605c8),
[`0ca0b7899`](Shopify@0ca0b78)]:
    -   @shopify/polaris@10.24.0
    -   @shopify/polaris-icons@6.10.0

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kyledurand kyledurand kyledurand approved these changes

@sarahill sarahill sarahill approved these changes

@heyjoethomas heyjoethomas Awaiting requested review from heyjoethomas

Assignees

@zecarlostorre zecarlostorre

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zecarlostorre @kyledurand @sarahill