[Layout foundations][Batch 2] Rebuild components with layout primitives #7821
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
size-limit report 📦
|
chazdean
force-pushed
the
layout-rebuild-batch-2
branch
from
6e6d97f to
08a5d05
Compare
laurkim
force-pushed
the
layout-rebuild-batch-2
branch
from
b39c6cc to
c63d455
Compare
laurkim
force-pushed
the
layout-rebuild-batch-2
branch
from
b3ea392 to
c85cb2d
Compare
4 tasks
chazdean
force-pushed
the
layout-rebuild-batch-2
branch
2 times, most recently
from
a5e1013 to
40b4d87
Compare
Contributor
|
/snapit |
Contributor
|
🫰✨ Thanks @aveline! Your snapshots have been published to npm. Test the snapshots by updating your yarn add @shopify/plugin-polaris@0.0.0-snapshot-release-20230116194107yarn add @shopify/polaris-migrator@0.0.0-snapshot-release-20230116194107yarn add @shopify/polaris@0.0.0-snapshot-release-20230116194107 |
Contributor
|
/snapit |
Contributor
|
🫰✨ Thanks @aveline! Your snapshots have been published to npm. Test the snapshots by updating your yarn add @shopify/plugin-polaris@0.0.0-snapshot-release-20230119153931yarn add @shopify/polaris-icons@0.0.0-snapshot-release-20230119153931yarn add @shopify/polaris@0.0.0-snapshot-release-20230119153931 |
Contributor
|
/snapit |
Contributor
|
🫰✨ Thanks @aveline! Your snapshots have been published to npm. Test the snapshots by updating your yarn add @shopify/plugin-polaris@0.0.0-snapshot-release-20230119211608yarn add @shopify/polaris@0.0.0-snapshot-release-20230119211608 |
sarahill
approved these changes
Jan 21, 2023
Contributor
sarahill
left a comment
sarahill
left a comment
There was a problem hiding this comment.
Looks good! The chromatic diffs for skeleton page look off but they look fine in storybook so I left them but I think this is good to go
Contributor
|
/snapit |
Contributor
|
🫰✨ Thanks @aveline! Your snapshots have been published to npm. Test the snapshots by updating your yarn add @shopify/plugin-polaris@0.0.0-snapshot-release-20230123181039yarn add @shopify/polaris-icons@0.0.0-snapshot-release-20230123181039yarn add @shopify/polaris@0.0.0-snapshot-release-20230123181039 |
laurkim
force-pushed
the
layout-rebuild-batch-2
branch
from
697bc5a to
a1ce883
Compare
Contributor
Author
|
/snapit |
Contributor
|
🫰✨ Thanks @laurkim! Your snapshots have been published to npm. Test the snapshots by updating your yarn add @shopify/plugin-polaris@0.0.0-snapshot-release-20230124211316yarn add @shopify/polaris@0.0.0-snapshot-release-20230124211316 |
aveline
approved these changes
Jan 25, 2023
nayeobkim
approved these changes
Jan 25, 2023
chazdean
approved these changes
Jan 25, 2023
sarahill
approved these changes
Jan 26, 2023
kyledurand
approved these changes
Jan 26, 2023
Member
kyledurand
left a comment
kyledurand
left a comment
There was a problem hiding this comment.
This looks pretty solid. Only thing I'm seeing is a slight difference in spacing on empty state. That could be intentional though
Closes: #7580 This slightly moves the checkbox handle 2px to the left. This means it now lines up with our 20px padding instead of 22px from the card edge. Also improves vertical alignment of the checkboxes and bulk select on xs screens Before | After ---|---  |  The only CSS that remains is for interactive elements, interactive behavior (hover, focus), and transitions (which are being removed in https://github.com/Shopify/polaris/pull/7290/files).
Fixes #7458 Co-authored-by: Lo Kim <lo.kim@shopify.com>
<!-- ☝️How to write a good PR title: - Prefix it with [ComponentName] (if applicable), for example: [Button] - Start with a verb, for example: Add, Delete, Improve, Fix… - Give as much context as necessary and as little as possible - Prefix it with [WIP] while it’s a work in progress --> Fixes [#7714](#7714) <!-- Context about the problem that’s being addressed. --> - Refactors `SkeletonPage` and its child components to use our layout primitives. - Removes `max-width: 100%` property from AlphaStack - Adds storybook examples for `SkeletonPage` with `narrowWidth` and with `fullWidth` props <details> <summary>Unable to center `SkeletonPage` when `narrowWidth` prop is used - SOLVED ✅</summary> <table> <tr> <td> Before </td> <td> After </td> </tr> <tr> <td> <img width="400" alt="Screenshot 2022-11-24 at 9 13 21 AM" src="https://user-images.githubusercontent.com/59836805/203805854-4748a46a-8208-476e-9c16-d0071e4ff66b.png"> </td> <td> <img width="400" alt="Screenshot 2022-11-24 at 9 10 25 AM" src="https://user-images.githubusercontent.com/59836805/203806188-bd5cde58-0787-46f1-a2b3-cbaf2a228d52.png"> </td> </tr> <tr> <td> <img width="400" alt="Screenshot 2022-11-24 at 9 13 42 AM" src="https://user-images.githubusercontent.com/59836805/203806392-466df6a0-29ee-4d06-bc40-523b60b97853.png"> </td> <td> <img width="400" alt="Screenshot 2022-11-24 at 9 11 17 AM" src="https://user-images.githubusercontent.com/59836805/203806492-6793f6a3-591a-4cb4-9f13-46da44f64dfe.png"> </td> </tr> </table> </details> <details> <summary>Our current `Text` component has the opposite breakpoint behaviour compared to how `.Title` is used in `SkeletonPage` - SOLVED ✅</summary> <table> <tr> <td> Before </td> <td> After </td> </tr> <tr> <td> <img width="400" alt="before text" src="https://user-images.githubusercontent.com/59836805/203808391-3f3bd9d2-421e-4e09-a843-e579b936d39f.gif"> </td> <td> <img width="400" alt="before text" src="https://user-images.githubusercontent.com/59836805/203808879-55e311ef-708b-44c9-a28e-4582c77d0992.gif"> </td> </tr> <tr> <td> ```java .Title { font-weight: var(--p-font-weight-semibold); font-size: 24px; line-height: 28px; @media #{$p-breakpoints-md-up} { font-size: 20px; } } ``` </td> <td> ```java .headingXl { font-size: var(--p-font-size-300); line-height: var(--p-font-line-height-3); @media #{$p-breakpoints-md-up} { font-size: var(--p-font-size-400); line-height: var(--p-font-line-height-4); } } ``` </td> </tr> </table> </details> ~~`role` prop is missing from `Box`, creating a separate issue to solve this [here](#7799 SOLVED ✅ <!-- Summary of the changes committed. Before / after screenshots are appreciated for UI changes. Make sure to include alt text that describes the screenshot. If you include an animated gif showing your change, wrapping it in a details tag is recommended. Gifs usually autoplay, which can cause accessibility issues for people reviewing your PR: <details> <summary>Summary of your gif(s)</summary> <img src="..." alt="Description of what the gif shows"> </details> --> <!-- ℹ️ Delete the following for small / trivial changes --> - [ ] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [ ] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide Co-authored-by: Lo Kim <lo.kim@shopify.com>
Fixes [#7564](#7564) - Remove max-width from AlphaStack - Rebuild EmptyState with layout components DEPENDS ON #7842. Merge that in first then bring `layout-rebuild-batch-2` up to date with `main` and then merge in those changes into this branch ### [✅ RESOLVED] UX Review There is a discrepancy in the size of the image container. The update `EmptyState` component image container is 5px smaller in height than the production one. The comparison below shows the production version (first) vs the update component (second). This results in about 5px additional whitespace in the prod version. This different is due to the production version relying on a flex property on the image container that we don't currently implement. Is this difference acceptable or should we adjust the image container size somehow? <details> <summary>Compare image container whitespace before and after</summary> https://user-images.githubusercontent.com/4642404/204934759-3363b103-5118-4335-ab87-79edaa5d0634.mov Production image size <img width="1071" alt="prod-size" src="https://user-images.githubusercontent.com/4642404/204935557-dc3ea1c8-778f-4644-8c2b-62d524b2f03b.png"> Updated ima <img width="1071" alt="updated-size" src="https://user-images.githubusercontent.com/4642404/204935620-be70ec16-0ece-432e-9105-64e94ba2525c.png"> </details> Co-authored-by: Kyle Durand <kyledurand@users.noreply.github.com> Co-authored-by: aveline <aveline@users.noreply.github.com> Co-authored-by: Lo Kim <lo.kim@shopify.com> Co-authored-by: Chaz Dean <59836805+chazdean@users.noreply.github.com>
…eletonPage to closer match Page (#8030) <!-- ☝️How to write a good PR title: - Prefix it with [ComponentName] (if applicable), for example: [Button] - Start with a verb, for example: Add, Delete, Improve, Fix… - Give as much context as necessary and as little as possible - Prefix it with [WIP] while it’s a work in progress --> ### WHY are these changes introduced? Fixes #8014 <!-- link to issue if one exists --> <!-- Context about the problem that’s being addressed. --> ### WHAT is this pull request doing? - Centers `SkeletonTitle` to align with `PrimaryActionSkeleton` on right - Reduces height of `SkeletonTitle` from `28px` to `24px` to closer match `Page` title - Removes `paddingBlockStart` from `SkeletonPage` Body allowing it shift up vertically matching `Page` Before| :----:| <img width="1007" alt="Screenshot 2023-01-11 at 3 48 06 PM" src="https://user-images.githubusercontent.com/59836805/211915956-c9ee9f44-e1c5-4e65-a91f-44678caf4f31.png">| **After**| <img width="1024" alt="Screenshot 2023-01-11 at 3 47 40 PM" src="https://user-images.githubusercontent.com/59836805/211916089-707a3af2-fb1f-4046-90bc-cb362bed2162.png">| <!-- Summary of the changes committed. Before / after screenshots are appreciated for UI changes. Make sure to include alt text that describes the screenshot. If you include an animated gif showing your change, wrapping it in a details tag is recommended. Gifs usually autoplay, which can cause accessibility issues for people reviewing your PR: <details> <summary>Summary of your gif(s)</summary> <img src="..." alt="Description of what the gif shows"> </details> --> <!-- ℹ️ Delete the following for small / trivial changes --> ### How to 🎩 [Spin Link](https://admin.web.web-6ubu.chaz-dean.us.spin.dev/store/shop1/) <!-- Give as much information as needed to experiment with the component in the playground. --> ### 🎩 checklist - [ ] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [ ] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
### WHY are these changes introduced? Fixes #8078 ### WHAT is this pull request doing? Removes left padding from header wrapper that's no longer necessary
…#8075) <!-- ☝️How to write a good PR title: - Prefix it with [ComponentName] (if applicable), for example: [Button] - Start with a verb, for example: Add, Delete, Improve, Fix… - Give as much context as necessary and as little as possible - Prefix it with [WIP] while it’s a work in progress --> ### WHY are these changes introduced? Adds consistency to `SkeletonPage` by giving the skeleton title a fixed height regardless if the `primaryAction` prop is being used or not <!-- Context about the problem that’s being addressed. --> ### WHAT is this pull request doing? - Centers the title skeleton by adding `blockStart` and `blockEnd` padding - Increases title height back to `28px` so that with `8px` of extra padding, title container can match the height of the `primaryAction` skeleton at `36px` #### With primaryAction skeleton <img width="1169" alt="Screenshot 2023-01-18 at 8 37 53 AM" src="https://user-images.githubusercontent.com/59836805/213186715-c011be36-398b-4b8e-8172-b842277cc50d.png"> #### Without primaryAction skeleton <img width="1171" alt="Screenshot 2023-01-18 at 8 38 50 AM" src="https://user-images.githubusercontent.com/59836805/213186743-1b3c6d38-4680-458f-a5c3-87206ee89914.png"> <!-- Summary of the changes committed. Before / after screenshots are appreciated for UI changes. Make sure to include alt text that describes the screenshot. If you include an animated gif showing your change, wrapping it in a details tag is recommended. Gifs usually autoplay, which can cause accessibility issues for people reviewing your PR: <details> <summary>Summary of your gif(s)</summary> <img src="..." alt="Description of what the gif shows"> </details> --> <!-- ℹ️ Delete the following for small / trivial changes --> ### How to 🎩 [Spin Link](https://admin.web.web-6n2m.chaz-dean.us.spin.dev/store/shop1/) (Updated) </details> ### 🎩 checklist - [ ] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [ ] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
Header alignment changed in #7965. Adjusting shortcut action spacing to match
laurkim
force-pushed
the
layout-rebuild-batch-2
branch
from
06ab6fc to
071e9d6
Compare
Merged
yurm04
pushed a commit
that referenced
this pull request
Jan 26, 2023
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @shopify/polaris-icons@6.10.0 ### Minor Changes - [#8150](#8150) [`a0c6e467b`](a0c6e46) Thanks [@leileu](https://github.com/leileu)! - Adding two metaobject icons: Metaobject and Metaobject Reference. ### Patch Changes - [#8148](#8148) [`0ca0b7899`](0ca0b78) Thanks [@zecarlostorre](https://github.com/zecarlostorre)! - Updated clipboard icon ## @shopify/polaris@10.24.0 ### Minor Changes - [#8083](#8083) [`18991daf1`](18991da) Thanks [@krithikajanakiraman](https://github.com/krithikajanakiraman)! - Adding an oprtional headerContent prop to ResourceList - [#7821](#7821) [`a0941743a`](a094174) Thanks [@laurkim](https://github.com/laurkim)! - Rebuilt `ActionList` to use layout primitives - [#7821](#7821) [`a0941743a`](a094174) Thanks [@laurkim](https://github.com/laurkim)! - Refactored `SkeletonPage` to use primitive Layout components Removed `max-width` on children in `AlphaStack` Added `narrowWidth` and `fullWidth` examples to `AlphaStack` stories ### Patch Changes - [#7821](#7821) [`a0941743a`](a094174) Thanks [@laurkim](https://github.com/laurkim)! - Updated `SkeletonPage` title and body layout - [#7821](#7821) [`a0941743a`](a094174) Thanks [@laurkim](https://github.com/laurkim)! - Refactored `SkeletonPage` title layout - [#7821](#7821) [`a0941743a`](a094174) Thanks [@laurkim](https://github.com/laurkim)! - Fixed `ResourceList` header alignment - [#7821](#7821) [`a0941743a`](a094174) Thanks [@laurkim](https://github.com/laurkim)! - Rebuilt `ResourceItem` with layout components - [#7821](#7821) [`a0941743a`](a094174) Thanks [@laurkim](https://github.com/laurkim)! - Fixed IndexTable checkbox alignment - [#8099](#8099) [`a3605c855`](a3605c8) Thanks [@AndrewMusgrave](https://github.com/AndrewMusgrave)! - Fixed `BulkActions` causing `IndexTable` & `ResourceList` to ignore pointer events - Updated dependencies \[[`a0c6e467b`](a0c6e46), [`0ca0b7899`](0ca0b78)]: - @shopify/polaris-icons@6.10.0 ## @shopify/plugin-polaris@0.0.31 ### Patch Changes - Updated dependencies \[]: - @shopify/polaris-migrator@0.11.2 ## @shopify/polaris-migrator@0.11.2 ### Patch Changes - Updated dependencies \[[`07669075a`](0766907), [`74a75a473`](74a75a4), [`f8f9eecd5`](f8f9eec)]: - @shopify/stylelint-polaris@5.1.2 ## @shopify/stylelint-polaris@5.1.2 ### Patch Changes - [#8167](#8167) [`07669075a`](0766907) Thanks [@aaronccasanova](https://github.com/aaronccasanova)! - Temporarily disable layout category - [#8162](#8162) [`74a75a473`](74a75a4) Thanks [@aaronccasanova](https://github.com/aaronccasanova)! - Allow SCSS namespaces with Polaris breakpoints - [#8168](#8168) [`f8f9eecd5`](f8f9eec) Thanks [@aaronccasanova](https://github.com/aaronccasanova)! - Ignored needless disables for layout category and added meta URL to error message ## polaris.shopify.com@0.30.1 ### Patch Changes - [#8123](#8123) [`3bb6c03d3`](3bb6c03) Thanks [@marlowpayne](https://github.com/marlowpayne)! - Improve readability of markdown tables by wrapping on words - [#8045](#8045) [`b3ee45c47`](b3ee45c) Thanks [@sarahill](https://github.com/sarahill)! - Added component lifecycle page to polaris.shopify.com - [#7821](#7821) [`a0941743a`](a094174) Thanks [@laurkim](https://github.com/laurkim)! - Rebuilt `ActionList` to use layout primitives - Updated dependencies \[[`a0941743a`](a094174), [`18991daf1`](18991da), [`a0941743a`](a094174), [`a0941743a`](a094174), [`a0941743a`](a094174), [`a0941743a`](a094174), [`a0941743a`](a094174), [`a0941743a`](a094174), [`a0c6e467b`](a0c6e46), [`a3605c855`](a3605c8), [`0ca0b7899`](0ca0b78)]: - @shopify/polaris@10.24.0 - @shopify/polaris-icons@6.10.0 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Merged
juzser
pushed a commit
to juzser/polaris
that referenced
this pull request
Jul 27, 2023
![https://user-images.githubusercontent.com/59836805/211915956-c9ee9f44-e1c5-4e65-a91f-44678caf4f31.png">|](https://user-images.githubusercontent.com/59836805/211915956-c9ee9f44-e1c5-4e65-a91f-44678caf4f31.png">|){kind=link}
![https://user-images.githubusercontent.com/59836805/211916089-707a3af2-fb1f-4046-90bc-cb362bed2162.png">|](https://user-images.githubusercontent.com/59836805/211916089-707a3af2-fb1f-4046-90bc-cb362bed2162.png">|){kind=link}
…es (Shopify#7821) ### WHY are these changes introduced? Related to [7565](Shopify#7565). ### WHAT is this pull request doing? Rebuilds the following components to use our layout primitives. - `ResourceItem` Shopify#7580 - `ActionList` Shopify#7458 - `SkeletonPage` Shopify#7714 - `EmptyState` Shopify#7564 Fixes - Shopify#8078 <!-- ℹ️ Delete the following for small / trivial changes --> ### How to 🎩 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) ### 🎩 checklist - [ ] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [ ] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide Co-authored-by: Kyle Durand <kyledurand@users.noreply.github.com> Co-authored-by: aveline <aveline@users.noreply.github.com> Co-authored-by: Chaz Dean <59836805+chazdean@users.noreply.github.com> Co-authored-by: Yuraima Estevez <yuraima.estevez@shopify.com>
juzser
pushed a commit
to juzser/polaris
that referenced
this pull request
Jul 27, 2023
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @shopify/polaris-icons@6.10.0 ### Minor Changes - [Shopify#8150](Shopify#8150) [`a0c6e467b`](Shopify@a0c6e46) Thanks [@leileu](https://github.com/leileu)! - Adding two metaobject icons: Metaobject and Metaobject Reference. ### Patch Changes - [Shopify#8148](Shopify#8148) [`0ca0b7899`](Shopify@0ca0b78) Thanks [@zecarlostorre](https://github.com/zecarlostorre)! - Updated clipboard icon ## @shopify/polaris@10.24.0 ### Minor Changes - [Shopify#8083](Shopify#8083) [`18991daf1`](Shopify@18991da) Thanks [@krithikajanakiraman](https://github.com/krithikajanakiraman)! - Adding an oprtional headerContent prop to ResourceList - [Shopify#7821](Shopify#7821) [`a0941743a`](Shopify@a094174) Thanks [@laurkim](https://github.com/laurkim)! - Rebuilt `ActionList` to use layout primitives - [Shopify#7821](Shopify#7821) [`a0941743a`](Shopify@a094174) Thanks [@laurkim](https://github.com/laurkim)! - Refactored `SkeletonPage` to use primitive Layout components Removed `max-width` on children in `AlphaStack` Added `narrowWidth` and `fullWidth` examples to `AlphaStack` stories ### Patch Changes - [Shopify#7821](Shopify#7821) [`a0941743a`](Shopify@a094174) Thanks [@laurkim](https://github.com/laurkim)! - Updated `SkeletonPage` title and body layout - [Shopify#7821](Shopify#7821) [`a0941743a`](Shopify@a094174) Thanks [@laurkim](https://github.com/laurkim)! - Refactored `SkeletonPage` title layout - [Shopify#7821](Shopify#7821) [`a0941743a`](Shopify@a094174) Thanks [@laurkim](https://github.com/laurkim)! - Fixed `ResourceList` header alignment - [Shopify#7821](Shopify#7821) [`a0941743a`](Shopify@a094174) Thanks [@laurkim](https://github.com/laurkim)! - Rebuilt `ResourceItem` with layout components - [Shopify#7821](Shopify#7821) [`a0941743a`](Shopify@a094174) Thanks [@laurkim](https://github.com/laurkim)! - Fixed IndexTable checkbox alignment - [Shopify#8099](Shopify#8099) [`a3605c855`](Shopify@a3605c8) Thanks [@AndrewMusgrave](https://github.com/AndrewMusgrave)! - Fixed `BulkActions` causing `IndexTable` & `ResourceList` to ignore pointer events - Updated dependencies \[[`a0c6e467b`](Shopify@a0c6e46), [`0ca0b7899`](Shopify@0ca0b78)]: - @shopify/polaris-icons@6.10.0 ## @shopify/plugin-polaris@0.0.31 ### Patch Changes - Updated dependencies \[]: - @shopify/polaris-migrator@0.11.2 ## @shopify/polaris-migrator@0.11.2 ### Patch Changes - Updated dependencies \[[`07669075a`](Shopify@0766907), [`74a75a473`](Shopify@74a75a4), [`f8f9eecd5`](Shopify@f8f9eec)]: - @shopify/stylelint-polaris@5.1.2 ## @shopify/stylelint-polaris@5.1.2 ### Patch Changes - [Shopify#8167](Shopify#8167) [`07669075a`](Shopify@0766907) Thanks [@aaronccasanova](https://github.com/aaronccasanova)! - Temporarily disable layout category - [Shopify#8162](Shopify#8162) [`74a75a473`](Shopify@74a75a4) Thanks [@aaronccasanova](https://github.com/aaronccasanova)! - Allow SCSS namespaces with Polaris breakpoints - [Shopify#8168](Shopify#8168) [`f8f9eecd5`](Shopify@f8f9eec) Thanks [@aaronccasanova](https://github.com/aaronccasanova)! - Ignored needless disables for layout category and added meta URL to error message ## polaris.shopify.com@0.30.1 ### Patch Changes - [Shopify#8123](Shopify#8123) [`3bb6c03d3`](Shopify@3bb6c03) Thanks [@marlowpayne](https://github.com/marlowpayne)! - Improve readability of markdown tables by wrapping on words - [Shopify#8045](Shopify#8045) [`b3ee45c47`](Shopify@b3ee45c) Thanks [@sarahill](https://github.com/sarahill)! - Added component lifecycle page to polaris.shopify.com - [Shopify#7821](Shopify#7821) [`a0941743a`](Shopify@a094174) Thanks [@laurkim](https://github.com/laurkim)! - Rebuilt `ActionList` to use layout primitives - Updated dependencies \[[`a0941743a`](Shopify@a094174), [`18991daf1`](Shopify@18991da), [`a0941743a`](Shopify@a094174), [`a0941743a`](Shopify@a094174), [`a0941743a`](Shopify@a094174), [`a0941743a`](Shopify@a094174), [`a0941743a`](Shopify@a094174), [`a0941743a`](Shopify@a094174), [`a0c6e467b`](Shopify@a0c6e46), [`a3605c855`](Shopify@a3605c8), [`0ca0b7899`](Shopify@0ca0b78)]: - @shopify/polaris@10.24.0 - @shopify/polaris-icons@6.10.0 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Related to 7565.
WHAT is this pull request doing?
Rebuilds the following components to use our layout primitives.
ResourceItem[Layout foundations] RebuildResourceItemwith layout components #7580ActionList[Layout foundations] RebuildActionListwith new layout primitives #7458SkeletonPage[Layout foundations] RebuildSkeletonPagewith new layout primitives #7714EmptyState[Layout foundations] RebuildEmptyStatewith new layout primitives #7564Fixes
How to 🎩
🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines
🎩 checklist
README.mdwith documentation changes