Temporarily enable layout rules for use on the coverage site
#8196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
/snapit |
Contributor
|
🫰✨ Thanks @aaronccasanova! Your snapshots have been published to npm. Test the snapshots by updating your yarn add @shopify/plugin-polaris@0.0.0-snapshot-release-20230127183913yarn add @shopify/polaris-migrator@0.0.0-snapshot-release-20230127183913yarn add @shopify/stylelint-polaris@0.0.0-snapshot-release-20230127183913 |
Member
Author
|
/snapit |
Contributor
|
🫰✨ Thanks @aaronccasanova! Your snapshots have been published to npm. Test the snapshots by updating your yarn add @shopify/polaris-cli@0.0.0-snapshot-release-20230224001120yarn add @shopify/polaris-migrator@0.0.0-snapshot-release-20230224001120yarn add @shopify/polaris@0.0.0-snapshot-release-20230224001120yarn add @shopify/polaris-tokens@0.0.0-snapshot-release-20230224001120yarn add @shopify/stylelint-polaris@0.0.0-snapshot-release-20230224001120 |
Contributor
size-limit report 📦
|
sam-b-rose
force-pushed
the
temp-stylelint-polaris-with-layout
branch
from
8038b64 to
b59e24b
Compare
Member
|
/snapit |
Contributor
|
🫰✨ Thanks @samrose3! Your snapshots have been published to npm. Test the snapshots by updating your yarn add @shopify/polaris-cli@0.0.0-snapshot-release-20230321142754yarn add @shopify/polaris-migrator@0.0.0-snapshot-release-20230321142754yarn add @shopify/polaris@0.0.0-snapshot-release-20230321142754yarn add @shopify/stylelint-polaris@0.0.0-snapshot-release-20230321142754 |
sam-b-rose
added a commit
that referenced
this pull request
Apr 26, 2023
### WHY are these changes introduced? Resolved #8193 Related #8196 <!-- Context about the problem that’s being addressed. --> ### WHAT is this pull request doing? We can re-enable the layout warnings now that Shopify/web silences warnings in the CI log. This will allow for warnings to be shown in VS Code while preventing them from adding noise to the log. Related web PR for testing: Shopify/web#90757
juzser
pushed a commit
to juzser/polaris
that referenced
this pull request
Jul 27, 2023
### WHY are these changes introduced? Resolved Shopify#8193 Related Shopify#8196 <!-- Context about the problem that’s being addressed. --> ### WHAT is this pull request doing? We can re-enable the layout warnings now that Shopify/web silences warnings in the CI log. This will allow for warnings to be shown in VS Code while preventing them from adding noise to the log. Related web PR for testing: https://github.com/Shopify/web/pull/90757
AnnaCheba
pushed a commit
to AnnaCheba/polaris
that referenced
this pull request
Apr 22, 2024
### WHY are these changes introduced? Resolved Shopify#8193 Related Shopify#8196 <!-- Context about the problem that’s being addressed. --> ### WHAT is this pull request doing? We can re-enable the layout warnings now that Shopify/web silences warnings in the CI log. This will allow for warnings to be shown in VS Code while preventing them from adding noise to the log. Related web PR for testing: Shopify/web#90757
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #8193