Re-enable layout warnings for coverage rules #9097
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
/snapit |
Contributor
|
🫰✨ Thanks @samrose3! Your snapshots have been published to npm. Test the snapshots by updating your yarn add @shopify/polaris-cli@0.0.0-snapshot-release-20230426121049yarn add @shopify/polaris-codemods@0.0.0-snapshot-release-20230426121049yarn add @shopify/polaris-migrator@0.0.0-snapshot-release-20230426121049yarn add @shopify/polaris@0.0.0-snapshot-release-20230426121049yarn add @shopify/stylelint-polaris@0.0.0-snapshot-release-20230426121049 |
laurkim
approved these changes
Apr 26, 2023
Merged
laurkim
pushed a commit
that referenced
this pull request
Apr 27, 2023
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @shopify/stylelint-polaris@12.0.0 ### Major Changes - [#9097](#9097) [`a64e38948`](a64e389) Thanks [@samrose3](https://github.com/samrose3)! - Re-enabled layout warnings for coverage rules ## @shopify/polaris@10.49.0 ### Minor Changes - [#9051](#9051) [`722b818b4`](722b818) Thanks [@camielvs](https://github.com/camielvs)! - Added `integer` option for the `type` prop of TextField ### Patch Changes - [#9108](#9108) [`6fd00eb7c`](6fd00eb) Thanks [@laurkim](https://github.com/laurkim)! - Refactored `Box` border radius properties to fix issues with cascading styles ## @shopify/polaris-cli@0.1.35 ### Patch Changes - Updated dependencies \[]: - @shopify/polaris-migrator@0.18.1 ## @shopify/polaris-codemods@0.1.1 ### Patch Changes - Updated dependencies \[[`a64e38948`](a64e389)]: - @shopify/stylelint-polaris@12.0.0 ## @shopify/polaris-migrator@0.18.1 ### Patch Changes - Updated dependencies \[[`a64e38948`](a64e389)]: - @shopify/stylelint-polaris@12.0.0 ## polaris.shopify.com@0.52.0 ### Minor Changes - [#9087](#9087) [`efdcb10db`](efdcb10) Thanks [@lgriffee](https://github.com/lgriffee)! - Updated instances of "spacing" on `/design/space` to "space". - [#9088](#9088) [`13e9b1e47`](13e9b1e) Thanks [@lgriffee](https://github.com/lgriffee)! - Matched v11 migration docs to migrations folder - [#9099](#9099) [`227490514`](2274905) Thanks [@chazdean](https://github.com/chazdean)! - Updated `ButtonGroup` examples to include `Pressed with segmented buttons` ### Patch Changes - [#9062](#9062) [`32dae8638`](32dae86) Thanks [@jesstelford](https://github.com/jesstelford)! - Merge /patterns-legacy index page into /patterns to ease discovery (includes a redirect so old links continue to work) - Updated dependencies \[[`722b818b4`](722b818), [`6fd00eb7c`](6fd00eb)]: - @shopify/polaris@10.49.0 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
juzser
pushed a commit
to juzser/polaris
that referenced
this pull request
Jul 27, 2023
### WHY are these changes introduced? Resolved Shopify#8193 Related Shopify#8196 <!-- Context about the problem that’s being addressed. --> ### WHAT is this pull request doing? We can re-enable the layout warnings now that Shopify/web silences warnings in the CI log. This will allow for warnings to be shown in VS Code while preventing them from adding noise to the log. Related web PR for testing: https://github.com/Shopify/web/pull/90757
juzser
pushed a commit
to juzser/polaris
that referenced
this pull request
Jul 27, 2023
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @shopify/stylelint-polaris@12.0.0 ### Major Changes - [Shopify#9097](Shopify#9097) [`a64e38948`](Shopify@a64e389) Thanks [@samrose3](https://github.com/samrose3)! - Re-enabled layout warnings for coverage rules ## @shopify/polaris@10.49.0 ### Minor Changes - [Shopify#9051](Shopify#9051) [`722b818b4`](Shopify@722b818) Thanks [@camielvs](https://github.com/camielvs)! - Added `integer` option for the `type` prop of TextField ### Patch Changes - [Shopify#9108](Shopify#9108) [`6fd00eb7c`](Shopify@6fd00eb) Thanks [@laurkim](https://github.com/laurkim)! - Refactored `Box` border radius properties to fix issues with cascading styles ## @shopify/polaris-cli@0.1.35 ### Patch Changes - Updated dependencies \[]: - @shopify/polaris-migrator@0.18.1 ## @shopify/polaris-codemods@0.1.1 ### Patch Changes - Updated dependencies \[[`a64e38948`](Shopify@a64e389)]: - @shopify/stylelint-polaris@12.0.0 ## @shopify/polaris-migrator@0.18.1 ### Patch Changes - Updated dependencies \[[`a64e38948`](Shopify@a64e389)]: - @shopify/stylelint-polaris@12.0.0 ## polaris.shopify.com@0.52.0 ### Minor Changes - [Shopify#9087](Shopify#9087) [`efdcb10db`](Shopify@efdcb10) Thanks [@lgriffee](https://github.com/lgriffee)! - Updated instances of "spacing" on `/design/space` to "space". - [Shopify#9088](Shopify#9088) [`13e9b1e47`](Shopify@13e9b1e) Thanks [@lgriffee](https://github.com/lgriffee)! - Matched v11 migration docs to migrations folder - [Shopify#9099](Shopify#9099) [`227490514`](Shopify@2274905) Thanks [@chazdean](https://github.com/chazdean)! - Updated `ButtonGroup` examples to include `Pressed with segmented buttons` ### Patch Changes - [Shopify#9062](Shopify#9062) [`32dae8638`](Shopify@32dae86) Thanks [@jesstelford](https://github.com/jesstelford)! - Merge /patterns-legacy index page into /patterns to ease discovery (includes a redirect so old links continue to work) - Updated dependencies \[[`722b818b4`](Shopify@722b818), [`6fd00eb7c`](Shopify@6fd00eb)]: - @shopify/polaris@10.49.0 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
AnnaCheba
pushed a commit
to AnnaCheba/polaris
that referenced
this pull request
Apr 22, 2024
### WHY are these changes introduced? Resolved Shopify#8193 Related Shopify#8196 <!-- Context about the problem that’s being addressed. --> ### WHAT is this pull request doing? We can re-enable the layout warnings now that Shopify/web silences warnings in the CI log. This will allow for warnings to be shown in VS Code while preventing them from adding noise to the log. Related web PR for testing: Shopify/web#90757
ascherkus
pushed a commit
to ascherkus/polaris
that referenced
this pull request
Feb 19, 2025
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @shopify/stylelint-polaris@12.0.0 ### Major Changes - [Shopify#9097](Shopify#9097) [`a64e38948`](Shopify@d289bb9) Thanks [@samrose3](https://github.com/samrose3)! - Re-enabled layout warnings for coverage rules ## @shopify/polaris@10.49.0 ### Minor Changes - [Shopify#9051](Shopify#9051) [`722b818b4`](Shopify@a7b28bf) Thanks [@camielvs](https://github.com/camielvs)! - Added `integer` option for the `type` prop of TextField ### Patch Changes - [Shopify#9108](Shopify#9108) [`6fd00eb7c`](Shopify@6c91a77) Thanks [@laurkim](https://github.com/laurkim)! - Refactored `Box` border radius properties to fix issues with cascading styles ## @shopify/polaris-cli@0.1.35 ### Patch Changes - Updated dependencies \[]: - @shopify/polaris-migrator@0.18.1 ## @shopify/polaris-codemods@0.1.1 ### Patch Changes - Updated dependencies \[[`a64e38948`](Shopify@d289bb9)]: - @shopify/stylelint-polaris@12.0.0 ## @shopify/polaris-migrator@0.18.1 ### Patch Changes - Updated dependencies \[[`a64e38948`](Shopify@d289bb9)]: - @shopify/stylelint-polaris@12.0.0 ## polaris.shopify.com@0.52.0 ### Minor Changes - [Shopify#9087](Shopify#9087) [`efdcb10db`](Shopify@1a72f1e) Thanks [@lgriffee](https://github.com/lgriffee)! - Updated instances of "spacing" on `/design/space` to "space". - [Shopify#9088](Shopify#9088) [`13e9b1e47`](Shopify@33a15a2) Thanks [@lgriffee](https://github.com/lgriffee)! - Matched v11 migration docs to migrations folder - [Shopify#9099](Shopify#9099) [`227490514`](Shopify@d525b82) Thanks [@chazdean](https://github.com/chazdean)! - Updated `ButtonGroup` examples to include `Pressed with segmented buttons` ### Patch Changes - [Shopify#9062](Shopify#9062) [`32dae8638`](Shopify@3c7b4fc) Thanks [@jesstelford](https://github.com/jesstelford)! - Merge /patterns-legacy index page into /patterns to ease discovery (includes a redirect so old links continue to work) - Updated dependencies \[[`722b818b4`](Shopify@a7b28bf), [`6fd00eb7c`](Shopify@6c91a77)]: - @shopify/polaris@10.49.0 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Resolved #8193
Related #8196
WHAT is this pull request doing?
We can re-enable the layout warnings now that Shopify/web silences warnings in the CI log. This will allow for warnings to be shown in VS Code while preventing them from adding noise to the log.
Related web PR for testing: https://github.com/Shopify/web/pull/90757