[Icon] Add any click attribution model minor icon #9049
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vngauv
changed the title
vngauv
force-pushed
the
add-anyclick-minor-icon
branch
from
81e4c53 to
71d9a14
Compare
kyledurand
approved these changes
Apr 21, 2023
Member
kyledurand
left a comment
kyledurand
left a comment
There was a problem hiding this comment.
👍 Just make sure the icon code is one line and not three before you ship, other than that it looks good!
.changeset/rude-kings-cheer.md
Outdated
| '@shopify/polaris-icons': minor | ||
| --- | ||
|
|
||
| Add any click attribution model icon |
Member
There was a problem hiding this comment.
Suggested change
| Add any click attribution model icon | |
| Added any click attribution model icon |
| @@ -0,0 +1,3 @@ | |||
| <svg viewBox="0 0 20 20" xmlns="http://www.w3.org/2000/svg"> | |||
| <path fill-rule="evenodd" d="M4 3C4.55228 3 5 3.44772 5 4L5 16C5 16.5523 4.55229 17 4 17C3.44772 17 3 16.5523 3 16L3 4C3 3.44772 3.44772 3 4 3ZM8 3C8.55228 3 9 3.44772 9 4L9 16C9 16.5523 8.55229 17 8 17C7.44772 17 7 16.5523 7 16L7 4C7 3.44772 7.44772 3 8 3ZM12 3C12.5523 3 13 3.44772 13 4V16C13 16.5523 12.5523 17 12 17C11.4477 17 11 16.5523 11 16V4C11 3.44772 11.4477 3 12 3ZM16 3C16.5523 3 17 3.44772 17 4V16C17 16.5523 16.5523 17 16 17C15.4477 17 15 16.5523 15 16V4C15 3.44772 15.4477 3 16 3Z" fill="#5C5F62"/> | |||
| </svg> | |||
Member
There was a problem hiding this comment.
This svg is looking good but can be single lined to match the other icons.
Merged
aaronccasanova
pushed a commit
that referenced
this pull request
Apr 22, 2023
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @shopify/polaris-icons@6.14.0 ### Minor Changes - [#9049](#9049) [`13b1a9109`](13b1a91) Thanks [@vngauv](https://github.com/vngauv)! - Added any click attribution model icon ## @shopify/polaris@10.47.1 ### Patch Changes - [#9057](#9057) [`65db7dd2b`](65db7dd) Thanks [@qt314](https://github.com/qt314)! - Fixed PopoverOverlay not closing - Updated dependencies \[[`13b1a9109`](13b1a91)]: - @shopify/polaris-icons@6.14.0 ## @shopify/polaris-cli@0.1.32 ## polaris.shopify.com@0.50.2 ### Patch Changes - Updated dependencies \[[`65db7dd2b`](65db7dd), [`13b1a9109`](13b1a91)]: - @shopify/polaris@10.47.1 - @shopify/polaris-icons@6.14.0 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
juzser
pushed a commit
to juzser/polaris
that referenced
this pull request
Jul 27, 2023
### WHY are these changes introduced? Fixes Shopify#8745 This icon represents the any click marketing attribution model. This icon will help merchants better understand visually how the any click model assigns credit upon selection on the marketing report. ### WHAT is this pull request doing? New icon. <img width="123" alt="image" src="https://user-images.githubusercontent.com/101414309/233702037-a75d0de2-0cc1-4c54-8f93-eb9ba142c790.png"> _https://www.figma.com/file/mMHFt3kEDNjLMZWowi6gnt/branch/QZnvslb5ZpgbamMG0v2bcy/Polaris-Icons?node-id=12859-211&t=dTAravG3ZhEV6IPZ-0_ ### 🎩 checklist - [ ] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [ ] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
juzser
pushed a commit
to juzser/polaris
that referenced
this pull request
Jul 27, 2023
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @shopify/polaris-icons@6.14.0 ### Minor Changes - [Shopify#9049](Shopify#9049) [`13b1a9109`](Shopify@13b1a91) Thanks [@vngauv](https://github.com/vngauv)! - Added any click attribution model icon ## @shopify/polaris@10.47.1 ### Patch Changes - [Shopify#9057](Shopify#9057) [`65db7dd2b`](Shopify@65db7dd) Thanks [@qt314](https://github.com/qt314)! - Fixed PopoverOverlay not closing - Updated dependencies \[[`13b1a9109`](Shopify@13b1a91)]: - @shopify/polaris-icons@6.14.0 ## @shopify/polaris-cli@0.1.32 ## polaris.shopify.com@0.50.2 ### Patch Changes - Updated dependencies \[[`65db7dd2b`](Shopify@65db7dd), [`13b1a9109`](Shopify@13b1a91)]: - @shopify/polaris@10.47.1 - @shopify/polaris-icons@6.14.0 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
AnnaCheba
pushed a commit
to AnnaCheba/polaris
that referenced
this pull request
Apr 22, 2024
### WHY are these changes introduced? Fixes Shopify#8745 This icon represents the any click marketing attribution model. This icon will help merchants better understand visually how the any click model assigns credit upon selection on the marketing report. ### WHAT is this pull request doing? New icon. <img width="123" alt="image" src="https://user-images.githubusercontent.com/101414309/233702037-a75d0de2-0cc1-4c54-8f93-eb9ba142c790.png"> _https://www.figma.com/file/mMHFt3kEDNjLMZWowi6gnt/branch/QZnvslb5ZpgbamMG0v2bcy/Polaris-Icons?node-id=12859-211&t=dTAravG3ZhEV6IPZ-0_ ### 🎩 checklist - [ ] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [ ] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
ascherkus
pushed a commit
to ascherkus/polaris
that referenced
this pull request
Feb 19, 2025
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @shopify/polaris-icons@6.14.0 ### Minor Changes - [Shopify#9049](Shopify#9049) [`13b1a9109`](Shopify@ffcfb8b) Thanks [@vngauv](https://github.com/vngauv)! - Added any click attribution model icon ## @shopify/polaris@10.47.1 ### Patch Changes - [Shopify#9057](Shopify#9057) [`65db7dd2b`](Shopify@02ceb6d) Thanks [@qt314](https://github.com/qt314)! - Fixed PopoverOverlay not closing - Updated dependencies \[[`13b1a9109`](Shopify@ffcfb8b)]: - @shopify/polaris-icons@6.14.0 ## @shopify/polaris-cli@0.1.32 ## polaris.shopify.com@0.50.2 ### Patch Changes - Updated dependencies \[[`65db7dd2b`](Shopify@02ceb6d), [`13b1a9109`](Shopify@ffcfb8b)]: - @shopify/polaris@10.47.1 - @shopify/polaris-icons@6.14.0 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fixes #8745
This icon represents the any click marketing attribution model. This icon will help merchants better understand visually how the any click model assigns credit upon selection on the marketing report.
WHAT is this pull request doing?
New icon.
https://www.figma.com/file/mMHFt3kEDNjLMZWowi6gnt/branch/QZnvslb5ZpgbamMG0v2bcy/Polaris-Icons?node-id=12859-211&t=dTAravG3ZhEV6IPZ-0
🎩 checklist
README.mdwith documentation changes