-
Notifications
You must be signed in to change notification settings - Fork 1.2k
[Popover] Fix PopoverOverlay not closing #9057
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
size-limit report 📦
|
Contributor
Author
|
/snapit |
Contributor
|
🫰✨ Thanks @sophschneider! Your snapshots have been published to npm. Test the snapshots by updating your yarn add @shopify/polaris-cli@0.0.0-snapshot-release-20230421234146yarn add @shopify/polaris-codemods@0.0.0-snapshot-release-20230421234146yarn add @shopify/polaris-migrator@0.0.0-snapshot-release-20230421234146yarn add @shopify/polaris@0.0.0-snapshot-release-20230421234146yarn add @shopify/polaris-tokens@0.0.0-snapshot-release-20230421234146yarn add @shopify/stylelint-polaris@0.0.0-snapshot-release-20230421234146 |
aaronccasanova
approved these changes
Apr 22, 2023
laurkim
reviewed
Apr 22, 2023
laurkim
approved these changes
Apr 22, 2023
Contributor
laurkim
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
400eb42 to
cee266a
Compare
Merged
aaronccasanova
pushed a commit
that referenced
this pull request
Apr 22, 2023
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @shopify/polaris-icons@6.14.0 ### Minor Changes - [#9049](#9049) [`13b1a9109`](13b1a91) Thanks [@vngauv](https://github.com/vngauv)! - Added any click attribution model icon ## @shopify/polaris@10.47.1 ### Patch Changes - [#9057](#9057) [`65db7dd2b`](65db7dd) Thanks [@qt314](https://github.com/qt314)! - Fixed PopoverOverlay not closing - Updated dependencies \[[`13b1a9109`](13b1a91)]: - @shopify/polaris-icons@6.14.0 ## @shopify/polaris-cli@0.1.32 ## polaris.shopify.com@0.50.2 ### Patch Changes - Updated dependencies \[[`65db7dd2b`](65db7dd), [`13b1a9109`](13b1a91)]: - @shopify/polaris@10.47.1 - @shopify/polaris-icons@6.14.0 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
juzser
pushed a commit
to juzser/polaris
that referenced
this pull request
Jul 27, 2023
Co-authored-by: Aaron Casanova <aaron.casanova@shopify.com> Co-authored-by: Lo Kim <lo.kim@shopify.com>
juzser
pushed a commit
to juzser/polaris
that referenced
this pull request
Jul 27, 2023
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @shopify/polaris-icons@6.14.0 ### Minor Changes - [Shopify#9049](Shopify#9049) [`13b1a9109`](Shopify@13b1a91) Thanks [@vngauv](https://github.com/vngauv)! - Added any click attribution model icon ## @shopify/polaris@10.47.1 ### Patch Changes - [Shopify#9057](Shopify#9057) [`65db7dd2b`](Shopify@65db7dd) Thanks [@qt314](https://github.com/qt314)! - Fixed PopoverOverlay not closing - Updated dependencies \[[`13b1a9109`](Shopify@13b1a91)]: - @shopify/polaris-icons@6.14.0 ## @shopify/polaris-cli@0.1.32 ## polaris.shopify.com@0.50.2 ### Patch Changes - Updated dependencies \[[`65db7dd2b`](Shopify@65db7dd), [`13b1a9109`](Shopify@13b1a91)]: - @shopify/polaris@10.47.1 - @shopify/polaris-icons@6.14.0 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
AnnaCheba
pushed a commit
to AnnaCheba/polaris
that referenced
this pull request
Apr 22, 2024
Co-authored-by: Aaron Casanova <aaron.casanova@shopify.com> Co-authored-by: Lo Kim <lo.kim@shopify.com>
ascherkus
pushed a commit
to ascherkus/polaris
that referenced
this pull request
Feb 19, 2025
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @shopify/polaris-icons@6.14.0 ### Minor Changes - [Shopify#9049](Shopify#9049) [`13b1a9109`](Shopify@ffcfb8b) Thanks [@vngauv](https://github.com/vngauv)! - Added any click attribution model icon ## @shopify/polaris@10.47.1 ### Patch Changes - [Shopify#9057](Shopify#9057) [`65db7dd2b`](Shopify@02ceb6d) Thanks [@qt314](https://github.com/qt314)! - Fixed PopoverOverlay not closing - Updated dependencies \[[`13b1a9109`](Shopify@ffcfb8b)]: - @shopify/polaris-icons@6.14.0 ## @shopify/polaris-cli@0.1.32 ## polaris.shopify.com@0.50.2 ### Patch Changes - Updated dependencies \[[`65db7dd2b`](Shopify@02ceb6d), [`13b1a9109`](Shopify@ffcfb8b)]: - @shopify/polaris@10.47.1 - @shopify/polaris-icons@6.14.0 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing bug where popovers weren't closing
this.clearTransitionTimeout();was removed in #8842, this adds it back inBefore
After
Playground code
Playground code
``` import React, {useState} from 'react';import {Popover, UnstyledButton} from '../src';
export function Playground() {
const [hoverActive, setHoverActive] = useState(false);
function handleClose() {
setHoverActive(false);
}
function handleActivatorMouseEnter() {
setHoverActive(true);
}
function handleActivatorMouseLeave() {
setHoverActive(false);
}
return (
<Popover
active={hoverActive}
activator={
hello world
}
onClose={handleClose}
>
hello world
);
}