Skip to content

Conversation

@sophschneider
Copy link
Contributor

@sophschneider sophschneider commented Apr 21, 2023

Fixing bug where popovers weren't closing

this.clearTransitionTimeout(); was removed in #8842, this adds it back in

Before

definition popover demo

After

def popover demo

Playground code

Playground code ``` import React, {useState} from 'react';

import {Popover, UnstyledButton} from '../src';

export function Playground() {
const [hoverActive, setHoverActive] = useState(false);

function handleClose() {
setHoverActive(false);
}

function handleActivatorMouseEnter() {
setHoverActive(true);
}

function handleActivatorMouseLeave() {
setHoverActive(false);
}

return (
<Popover
active={hoverActive}
activator={

hello world

}
onClose={handleClose}
>
hello world

);
}

</details>

@sophschneider sophschneider changed the title bug in playground popover bug in playground Apr 21, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Apr 21, 2023

size-limit report 📦

Path Size
polaris-react-cjs 241.16 KB (+0.01% 🔺)
polaris-react-esm 156.94 KB (+0.01% 🔺)
polaris-react-esnext 219.37 KB (+0.01% 🔺)
polaris-react-css 47.48 KB (0%)

@sophschneider
Copy link
Contributor Author

/snapit

@github-actions
Copy link
Contributor

github-actions bot commented Apr 21, 2023

🫰✨ Thanks @sophschneider! Your snapshots have been published to npm.

Test the snapshots by updating your package.json with the newly published versions:

yarn add @shopify/polaris-cli@0.0.0-snapshot-release-20230421234146
yarn add @shopify/polaris-codemods@0.0.0-snapshot-release-20230421234146
yarn add @shopify/polaris-migrator@0.0.0-snapshot-release-20230421234146
yarn add @shopify/polaris@0.0.0-snapshot-release-20230421234146
yarn add @shopify/polaris-tokens@0.0.0-snapshot-release-20230421234146
yarn add @shopify/stylelint-polaris@0.0.0-snapshot-release-20230421234146

@sophschneider sophschneider changed the title popover bug in playground [Popover] Fix PopoverOverlay not closing Apr 22, 2023
@sophschneider sophschneider marked this pull request as ready for review April 22, 2023 00:08
Copy link
Contributor

@laurkim laurkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@aaronccasanova aaronccasanova merged commit 65db7dd into main Apr 22, 2023
@aaronccasanova aaronccasanova deleted the popover-bug branch April 22, 2023 00:35
aaronccasanova pushed a commit that referenced this pull request Apr 22, 2023
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## @shopify/polaris-icons@6.14.0

### Minor Changes

- [#9049](#9049)
[`13b1a9109`](13b1a91)
Thanks [@vngauv](https://github.com/vngauv)! - Added any click
attribution model icon

## @shopify/polaris@10.47.1

### Patch Changes

- [#9057](#9057)
[`65db7dd2b`](65db7dd)
Thanks [@qt314](https://github.com/qt314)! - Fixed PopoverOverlay not
closing

- Updated dependencies
\[[`13b1a9109`](13b1a91)]:
    -   @shopify/polaris-icons@6.14.0

## @shopify/polaris-cli@0.1.32



## polaris.shopify.com@0.50.2

### Patch Changes

- Updated dependencies
\[[`65db7dd2b`](65db7dd),
[`13b1a9109`](13b1a91)]:
    -   @shopify/polaris@10.47.1
    -   @shopify/polaris-icons@6.14.0

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
juzser pushed a commit to juzser/polaris that referenced this pull request Jul 27, 2023
Co-authored-by: Aaron Casanova <aaron.casanova@shopify.com>
Co-authored-by: Lo Kim <lo.kim@shopify.com>
juzser pushed a commit to juzser/polaris that referenced this pull request Jul 27, 2023
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## @shopify/polaris-icons@6.14.0

### Minor Changes

- [Shopify#9049](Shopify#9049)
[`13b1a9109`](Shopify@13b1a91)
Thanks [@vngauv](https://github.com/vngauv)! - Added any click
attribution model icon

## @shopify/polaris@10.47.1

### Patch Changes

- [Shopify#9057](Shopify#9057)
[`65db7dd2b`](Shopify@65db7dd)
Thanks [@qt314](https://github.com/qt314)! - Fixed PopoverOverlay not
closing

- Updated dependencies
\[[`13b1a9109`](Shopify@13b1a91)]:
    -   @shopify/polaris-icons@6.14.0

## @shopify/polaris-cli@0.1.32



## polaris.shopify.com@0.50.2

### Patch Changes

- Updated dependencies
\[[`65db7dd2b`](Shopify@65db7dd),
[`13b1a9109`](Shopify@13b1a91)]:
    -   @shopify/polaris@10.47.1
    -   @shopify/polaris-icons@6.14.0

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
AnnaCheba pushed a commit to AnnaCheba/polaris that referenced this pull request Apr 22, 2024
Co-authored-by: Aaron Casanova <aaron.casanova@shopify.com>
Co-authored-by: Lo Kim <lo.kim@shopify.com>
ascherkus pushed a commit to ascherkus/polaris that referenced this pull request Feb 19, 2025
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## @shopify/polaris-icons@6.14.0

### Minor Changes

- [Shopify#9049](Shopify#9049)
[`13b1a9109`](Shopify@ffcfb8b)
Thanks [@vngauv](https://github.com/vngauv)! - Added any click
attribution model icon

## @shopify/polaris@10.47.1

### Patch Changes

- [Shopify#9057](Shopify#9057)
[`65db7dd2b`](Shopify@02ceb6d)
Thanks [@qt314](https://github.com/qt314)! - Fixed PopoverOverlay not
closing

- Updated dependencies
\[[`13b1a9109`](Shopify@ffcfb8b)]:
    -   @shopify/polaris-icons@6.14.0

## @shopify/polaris-cli@0.1.32



## polaris.shopify.com@0.50.2

### Patch Changes

- Updated dependencies
\[[`65db7dd2b`](Shopify@02ceb6d),
[`13b1a9109`](Shopify@ffcfb8b)]:
    -   @shopify/polaris@10.47.1
    -   @shopify/polaris-icons@6.14.0

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants