Run rollup once, to generate both cjs and es-modules bundles #912
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we ran rollup for twice, but as the only thing that differs is the output format that's not needed. This reduces the build time by ~5.5 seconds (~15%)
amrocha
reviewed
Jan 22, 2019
That's what the tophat instructions do. No changes occur. |
amrocha
approved these changes
Jan 22, 2019
|
I'm confident enough to merge. Thanks for the ✅ |
|
Would you mind following up with an entry in the "code quality" section? While I have a very high degree of confidence this is fine, on the off chance it causes some bizarre issue we have a more easily identifiable milestone for posterity. Also, because asserting that the build is indeed unaffected is a manual process we have more expose there. |
Also, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Gotta go fast.
Previously we ran rollup for twice, but as the only thing that differs
is the output format that's not needed.
This reduces the build time by ~5.5 seconds (~15%) which is particularly nice if you spend time waiting for
build-consumerto run or waiting forbuild.test.jsto complete when running the test suite.WHAT is this pull request doing?
Runs rollup() once, then generate both the cjs and the es-modules files from that single run.
As we're only running rollup() once we can also remove a bunch of conditionals from the config generation leading to simpler configuration
How to 🎩
git checkout master && mkdir master-build/node_modules/@shopify && yarn run build-consumer polaris-react/master-buildgit checkout run-rollup-once && mkdir new-build/node_modules/@shopify && yarn run build-consumer polaris-react/new-builddiff -r -u master-build new-build