Restructure Select override selectors
#9556
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sophschneider
approved these changes
Jun 28, 2023
Member
Author
|
/snapit |
aaronccasanova
added
the
🤖Skip Changelog
sam-b-rose
approved these changes
Jun 28, 2023
Member
Author
|
/snapit |
Contributor
|
🫰✨ Thanks @aaronccasanova! Your snapshots have been published to npm. Test the snapshots by updating your yarn add @shopify/polaris-cli@0.0.0-snapshot-release-20230628195344yarn add @shopify/polaris@0.0.0-snapshot-release-20230628195344 |
Merged
kyledurand
pushed a commit
that referenced
this pull request
Jun 30, 2023
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @shopify/polaris-icons@7.2.0 ### Minor Changes - [#9581](#9581) [`991d9fe69`](991d9fe) Thanks [@Rusty-UX](https://github.com/Rusty-UX)! - Added BoldMajor, BoldMinor, IndentMajor, IndentMinor, ItalicMajor, ItalicMinor, OrderedListMajor, OrderedListMinor, OutdentMajor, OutdentMinor, TextColorMajor, TextColorMinor, UnderlineMajor, UnderlineMinor icons - [#9580](#9580) [`75f08f32c`](75f08f3) Thanks [@kyledurand](https://github.com/kyledurand)! - Added optimize script ## @shopify/polaris@11.3.1 ### Patch Changes - [#9556](#9556) [`c72d2f905`](c72d2f9) Thanks [@aaronccasanova](https://github.com/aaronccasanova)! - Restructured `Select` override selectors to patch Sass compilation issue - [#9031](#9031) [`795ae3782`](795ae37) Thanks [@danbrady](https://github.com/danbrady)! - Added support for `Avatar` being presentational - Updated dependencies \[[`991d9fe69`](991d9fe), [`75f08f32c`](75f08f3)]: - @shopify/polaris-icons@7.2.0 ## @shopify/polaris-cli@0.2.10 ## polaris.shopify.com@0.55.8 ### Patch Changes - Updated dependencies \[[`c72d2f905`](c72d2f9), [`795ae3782`](795ae37), [`991d9fe69`](991d9fe), [`75f08f32c`](75f08f3)]: - @shopify/polaris@11.3.1 - @shopify/polaris-icons@7.2.0 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
juzser
pushed a commit
to juzser/polaris
that referenced
this pull request
Jul 27, 2023
This PR restructures the `Select` component override selectors as a quick fix to a Sass compilation issue. We are still unpacking why the original selector is not compiling as expected, but here is what @qt314 and I have discovered thus far: **Selector:** ✅ `#{$se23} &:hover:not(.disabled) .Backdrop` A single selector (`.disabled`) in the `:not()` pseudo-class selector list compiles as expected  **Selector:** ❌ `#{$se23} &:hover:not(.disabled, .error) .Backdrop` Multiple selectors (`.disabled, .error`) in the `:not()` pseudo-class selector list completely omits `:not()` when compiled  **Selector:** ✅ `#{$se23} &:hover:not(disabled) .Backdrop, #{$se23} &:hover:not(.error) .Backdrop` ~Splitting `:not()` into a separate grouped selector list compiles as expected with the tradeoff of doubling the override selector output.~ UPDATE: An improved pattern was found (see below).  There are a few areas of interest we intent to explore for resolving the underlying issue. However, I think the proposed fix and tradeoffs outlined above are an acceptable patch, addresses the issue observed in staging, and can be followed up with a proper solution when it is found. UPDATE: **Selector:** ✅ `#{$se23} &:not(.disabled):not(.error)` Chaining `:not()` pseudo-classes compiles as expected and avoids the duplicate override selector output 
juzser
pushed a commit
to juzser/polaris
that referenced
this pull request
Jul 27, 2023
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @shopify/polaris-icons@7.2.0 ### Minor Changes - [Shopify#9581](Shopify#9581) [`991d9fe69`](Shopify@991d9fe) Thanks [@Rusty-UX](https://github.com/Rusty-UX)! - Added BoldMajor, BoldMinor, IndentMajor, IndentMinor, ItalicMajor, ItalicMinor, OrderedListMajor, OrderedListMinor, OutdentMajor, OutdentMinor, TextColorMajor, TextColorMinor, UnderlineMajor, UnderlineMinor icons - [Shopify#9580](Shopify#9580) [`75f08f32c`](Shopify@75f08f3) Thanks [@kyledurand](https://github.com/kyledurand)! - Added optimize script ## @shopify/polaris@11.3.1 ### Patch Changes - [Shopify#9556](Shopify#9556) [`c72d2f905`](Shopify@c72d2f9) Thanks [@aaronccasanova](https://github.com/aaronccasanova)! - Restructured `Select` override selectors to patch Sass compilation issue - [Shopify#9031](Shopify#9031) [`795ae3782`](Shopify@795ae37) Thanks [@danbrady](https://github.com/danbrady)! - Added support for `Avatar` being presentational - Updated dependencies \[[`991d9fe69`](Shopify@991d9fe), [`75f08f32c`](Shopify@75f08f3)]: - @shopify/polaris-icons@7.2.0 ## @shopify/polaris-cli@0.2.10 ## polaris.shopify.com@0.55.8 ### Patch Changes - Updated dependencies \[[`c72d2f905`](Shopify@c72d2f9), [`795ae3782`](Shopify@795ae37), [`991d9fe69`](Shopify@991d9fe), [`75f08f32c`](Shopify@75f08f3)]: - @shopify/polaris@11.3.1 - @shopify/polaris-icons@7.2.0 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
AnnaCheba
pushed a commit
to AnnaCheba/polaris
that referenced
this pull request
Apr 22, 2024
This PR restructures the `Select` component override selectors as a quick fix to a Sass compilation issue. We are still unpacking why the original selector is not compiling as expected, but here is what @qt314 and I have discovered thus far: **Selector:** ✅ `#{$se23} &:hover:not(.disabled) .Backdrop` A single selector (`.disabled`) in the `:not()` pseudo-class selector list compiles as expected  **Selector:** ❌ `#{$se23} &:hover:not(.disabled, .error) .Backdrop` Multiple selectors (`.disabled, .error`) in the `:not()` pseudo-class selector list completely omits `:not()` when compiled  **Selector:** ✅ `#{$se23} &:hover:not(disabled) .Backdrop, #{$se23} &:hover:not(.error) .Backdrop` ~Splitting `:not()` into a separate grouped selector list compiles as expected with the tradeoff of doubling the override selector output.~ UPDATE: An improved pattern was found (see below).  There are a few areas of interest we intent to explore for resolving the underlying issue. However, I think the proposed fix and tradeoffs outlined above are an acceptable patch, addresses the issue observed in staging, and can be followed up with a proper solution when it is found. UPDATE: **Selector:** ✅ `#{$se23} &:not(.disabled):not(.error)` Chaining `:not()` pseudo-classes compiles as expected and avoids the duplicate override selector output 
ascherkus
pushed a commit
to ascherkus/polaris
that referenced
this pull request
Feb 19, 2025
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @shopify/polaris-icons@7.2.0 ### Minor Changes - [Shopify#9581](Shopify#9581) [`991d9fe69`](Shopify@a847d9c) Thanks [@Rusty-UX](https://github.com/Rusty-UX)! - Added BoldMajor, BoldMinor, IndentMajor, IndentMinor, ItalicMajor, ItalicMinor, OrderedListMajor, OrderedListMinor, OutdentMajor, OutdentMinor, TextColorMajor, TextColorMinor, UnderlineMajor, UnderlineMinor icons - [Shopify#9580](Shopify#9580) [`75f08f32c`](Shopify@01fb273) Thanks [@kyledurand](https://github.com/kyledurand)! - Added optimize script ## @shopify/polaris@11.3.1 ### Patch Changes - [Shopify#9556](Shopify#9556) [`c72d2f905`](Shopify@0c270b0) Thanks [@aaronccasanova](https://github.com/aaronccasanova)! - Restructured `Select` override selectors to patch Sass compilation issue - [Shopify#9031](Shopify#9031) [`795ae3782`](Shopify@c68e956) Thanks [@danbrady](https://github.com/danbrady)! - Added support for `Avatar` being presentational - Updated dependencies \[[`991d9fe69`](Shopify@a847d9c), [`75f08f32c`](Shopify@01fb273)]: - @shopify/polaris-icons@7.2.0 ## @shopify/polaris-cli@0.2.10 ## polaris.shopify.com@0.55.8 ### Patch Changes - Updated dependencies \[[`c72d2f905`](Shopify@0c270b0), [`795ae3782`](Shopify@c68e956), [`991d9fe69`](Shopify@a847d9c), [`75f08f32c`](Shopify@01fb273)]: - @shopify/polaris@11.3.1 - @shopify/polaris-icons@7.2.0 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR restructures the
Selectcomponent override selectors as a quick fix to a Sass compilation issue. We are still unpacking why the original selector is not compiling as expected, but here is what @sophschneider and I have discovered thus far:Selector: ✅
#{$se23} &:hover:not(.disabled) .BackdropA single selector (
.disabled) in the:not()pseudo-class selector list compiles as expectedSelector: ❌
#{$se23} &:hover:not(.disabled, .error) .BackdropMultiple selectors (
.disabled, .error) in the:not()pseudo-class selector list completely omits:not()when compiledSelector: ✅
#{$se23} &:hover:not(disabled) .Backdrop, #{$se23} &:hover:not(.error) .BackdropSplittingUPDATE: An improved pattern was found (see below).:not()into a separate grouped selector list compiles as expected with the tradeoff of doubling the override selector output.There are a few areas of interest we intent to explore for resolving the underlying issue. However, I think the proposed fix and tradeoffs outlined above are an acceptable patch, addresses the issue observed in staging, and can be followed up with a proper solution when it is found.
UPDATE:
Selector: ✅
#{$se23} &:not(.disabled):not(.error)Chaining
:not()pseudo-classes compiles as expected and avoids the duplicate override selector output