Convert :not pseudo-class selector list to chained
#9561
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronccasanova
requested review from
chloerice,
gwyneplaine,
jesstelford,
sam-b-rose and
sophschneider
aaronccasanova
added
the
🤖Skip Changelog
sophschneider
approved these changes
Jun 28, 2023
aaronccasanova
commented
Jun 28, 2023
| } | ||
| } | ||
|
|
||
| &:not(.hasBulkActions, .selectMode) { |
Member
Author
There was a problem hiding this comment.
Note: This PR updates a mainline :not psuedo-class (e.g. not beta-flagged) (Screenshot in PR description)
Member
Author
|
/snapit |
…t-selector-lists
Member
Author
|
/snapit |
Contributor
|
🫰✨ Thanks @aaronccasanova! Your snapshots have been published to npm. Test the snapshots by updating your yarn add @shopify/polaris-cli@0.0.0-snapshot-release-20230629184630yarn add @shopify/polaris@0.0.0-snapshot-release-20230629184630 |
chloerice
approved these changes
Jun 29, 2023
Member
chloerice
left a comment
chloerice
left a comment
There was a problem hiding this comment.
Thank you so much for flagging and fixing this Aaron!!
sam-b-rose
approved these changes
Jun 29, 2023
Member
sam-b-rose
left a comment
sam-b-rose
left a comment
There was a problem hiding this comment.
I do:not:not approve this PR 👍 💯 nice work catching this
chloerice
reviewed
Jun 29, 2023
| } | ||
|
|
||
| #{$se23} &:not(.focused, .isDisabled) { | ||
| #{$se23} &:not(.focused):not(.isDisabled) { |
chloerice
reviewed
Jun 29, 2023
| } | ||
|
|
||
| &:not(.hasBulkActions, .selectMode) { | ||
| &:not(.hasBulkActions):not(.selectMode) { |
Member
There was a problem hiding this comment.
Tophat of ProductDetails OptionsAndVariantsCard with multi-location looks good 👍🏽
Member
Author
|
Thanks for the tophatting assistance @chloerice ❤️ |
chloerice
reviewed
Jun 29, 2023
|
|
||
| #{$se23} &:hover, | ||
| #{$se23} &:focus:not(:active, .pressed, .disabled) { | ||
| #{$se23} &:focus:not(:active):not(.pressed):not(.disabled) { |
juzser
pushed a commit
to juzser/polaris
that referenced
this pull request
Jul 27, 2023
AnnaCheba
pushed a commit
to AnnaCheba/polaris
that referenced
this pull request
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of PR# 9556 applying the quick fix to all
:notpsuedo-classes with a selector list.Non-exhaustive pattern to find
:notpsuedo-classes with a selector list: